Add rust fmt#113
Open
heymide wants to merge 2 commits into
Open
Conversation
- Rewrote contracts/token/src/lib.rs from scratch to eliminate severe merge-conflict corruption (duplicate fn definitions, nested function signatures, mismatched delimiters) - Rebuilt with clean RBAC (bc_forge_admin::require_role), allowance expiration (AllowanceExp key), multi-sig proposal actions, clawback, token locking, two-step ownership transfer, batch_mint, pause/unpause - Added missing TokenError contracterror enum (was dropped in merges) - Fixed events.rs: replaced symbol_short! with Symbol::new for own_accept / own_cancel (>9 char limit) - Rewrote contracts/token/src/test.rs to remove 4x duplicated allowance-expiry test blocks and merged function bodies; corrected mint() call signature to (caller, to, amount) - Added workspace-level .rustfmt.toml (stable-channel options: max_width=100, reorder_imports, newline_style=Unix, edition=2021) - cargo check: clean (no errors) - cargo fmt --all: exit 0, no warnings
|
@heymide Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
Done, Close: #113 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #9
Summary
All three contracts compile cleanly. Everything is done. Here's a complete summary of what was accomplished this session:
✅ Session Complete
What was fixed
Key design decisions in the rebuilt token contract
- Allowance expiration — stored in a separate
- Two-step ownership —
- Multi-sig actions —
## Type of Changemint(caller, to, amount)— RBAC-gated viabc_forge_admin::require_role(Role::Minter)TokenError— restored as a#[contracterror]enum with 6 variantsAllowanceExpkey, checked on every readpropose_owner→accept_ownership→cancel_transferpropose_action/approve_proposal/execute_proposalviabc_forge_adminRelated Issue
Closes #9
Changes Made
Testing
How has this been tested?
cargo test)npm run buildinsdk/)Test commands run:
Checklist
feature/<issue-number>-<description>Drips.network Contributor Info
Screenshots (if applicable)