feat(token): separate minter role from admin role#112
Open
oche2920 wants to merge 1 commit into
Open
Conversation
- Add DataKey::Minter(Address) to token contract storage keys - Add grant_minter/revoke_minter admin-only functions - Add is_minter query function - Update mint and batch_mint to require Role::Minter instead of admin - Emit mtr_grnt/mtr_rvk events on role changes - Fix AdminKey enum: move AdminPool, Threshold, Proposal, ProposalIdCounter out of Role enum where they were incorrectly merged - Fix missing closing braces in admin has_role and require_role (merge artifacts) - Fix symbol_short names exceeding 9-char limit in events.rs - Clean up duplicate use statements and function bodies in token lib.rs - Update all tests and proptests to use new mint(minter, to, amount) signature Closes BCPathway#54
|
@oche2920 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@oche2920 please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(token): separate minter role from admin role
out of Role enum where they were incorrectly merged
Closes #54