Skip to content

[STU-176] Fix CodeRabbit nitpicks — portalIcons typing and fragile index logic #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BAWES merged 1 commit into from
May 21, 2026
Merged

[STU-176] Fix CodeRabbit nitpicks — portalIcons typing and fragile index logic #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/app/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { ThemeToggle } from "@/modules/theme/ThemeToggle";

export const dynamic = "force-dynamic";

const portalIcons: Record<string, string> = {
const portalIcons: Record<(typeof portalRoles)[number], string> = {
candidate: "🎓",
staff: "📋",
company: "🏭",
Expand Down Expand Up @@ -66,10 +66,15 @@ export default async function Home() {
<small>80 results · filtered · ready for review</small>
</div>
<div className="landingOpsColumns">
{["Profile", "CV export", "Timesheet", "Payment"].map((item, index) => (
<div key={item}>
<span>{item}</span>
<strong>{index === 1 ? "PDF" : "Live"}</strong>
{[
{ label: "Profile", status: "Live" },
{ label: "CV export", status: "PDF" },
{ label: "Timesheet", status: "Live" },
{ label: "Payment", status: "Live" },
].map((item) => (
<div key={item.label}>
<span>{item.label}</span>
<strong>{item.status}</strong>
</div>
))}
</div>
Expand Down
Loading