Enforce CFSClean network isolation in 1ES pipelines - #1023
Merged
Conversation
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot
AI
changed the title
Enforce CFSClean network isolation
Enforce CFSClean network isolation in 1ES pipelines
Aug 5, 2026
Copilot created this pull request from a session on behalf of
Mike Harder (mikeharder)
August 5, 2026 03:59
View session
Member
|
Daniel Jurek (@danieljurek): I think this PR is a step in the right direction. Currently failing installing rust deps: |
CFSClean network isolation blocks direct crates.io access, so cargo must resolve crates through the azure-sdk-for-rust feed instead. Add config-cargo.yml to set-env.yaml, the shared step template included by all four registered pipelines (ci, publish-release, typespec-spector, and ci-typespec-nightly). All cargo invocations live in build-test.yaml, which always runs after set-env.yaml, so a single reference covers every pipeline. Also move config.toml.template from eng/template to eng/templates to match the path config-cargo.yml copies from and the azure-sdk-for-rust layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d9f988a-e7bc-4959-a467-789804f3221c
Member
|
Mike Harder (@mikeharder) this is fixed |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the repo’s Azure DevOps 1ES pipelines for CFSClean network isolation by routing Cargo (crates.io) through the Centralized Feed Service (CFS) and by installing pnpm directly from the version declared in package.json rather than using Corepack.
Changes:
- Set 1ES pipeline
networkIsolationPolicytoPermissive, CFSClean. - Add a Cargo config template and pipeline step to copy it into
$CARGO_HOME/config.tomland authenticate to theazure-sdk-for-rustfeed. - Replace Corepack-based pnpm setup with
npm install -gof the exactpackageManagerspec frompackage.json.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/templates/config.toml.template | New Cargo config template intended to redirect crates.io to the Azure DevOps CFS-backed registry. |
| eng/pipelines/templates/steps/set-env.yaml | Switch pnpm installation approach and add the cargo configuration/authentication step into the shared environment setup. |
| eng/pipelines/templates/steps/config-cargo.yml | New pipeline step to install Cargo config into $CARGO_HOME and run CargoAuthenticate@0. |
| eng/pipelines/templates/stages/1es-redirect.yml | Enable CFSClean network isolation policy for 1ES template usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the pipeline hardening from Azure/autorest#5194 to support CFSClean-isolated builds.
Changes
Network isolation
Permissive, CFSClean.Package manager setup
npm install -g.package.json.