Scope package size report to this repo's packages and colorize deltas - #5184
Merged
iscai-msft merged 2 commits intoAug 7, 2026
Merged
Conversation
Contributor
|
No changes needing a change description found. |
Contributor
📦 Package size report✅ No notable package size changes compared to the base branch. 13 package(s) with no notable change
Packed = gzipped |
Contributor
|
You can try these changes here
|
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
August 7, 2026 15:08
Timothee Guerin (timotheeguerin)
requested review from
Mark Cowlishaw (markcowl) and
Jeff Fisher (xirzec)
as code owners
August 7, 2026 15:08
iscai-msft
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package size check reports noise. On #5182 — a core submodule bump — it claimed 25 packages changed size, most by a handful of bytes. Two independent causes, both fixed here.
It measured the
core/submodule. Those packages are published frommicrosoft/typespec; no PR here can change their published size. They're also measured unreliably — 11 of them ship.turbo/turbo-build.log, which captures the compiler version banner and CLI spinner frames, so their tarball size shifts on every build (filed as microsoft/typespec#11589). Measurement is now scoped to this repo'spackages/, taking the report from 45 packages down to the 13 we actually publish.Rebuilding isn't byte-reproducible, so every package wobbled.
@azure-tools/typespec-javais the clearest case: it ships a Maven jar whose zip entries carry wall-clock build timestamps. The workflow builds head and base minutes apart, so those bytes differ while the jar's length doesn't — the packed size moves a few dozen bytes and the unpacked delta is exactly zero. The report duly announced it as a change.Deltas now need to clear both a byte floor and a percentage floor to count, mirroring
isNotableMetricChangeinpackages/benchmark/src/compare.ts. Sub-threshold rows drop into the collapsed section instead of leading the comment:@azure-tools/typespec-metadata🆕@azure-tools/typespec-azure-core2 package(s) with no notable change
@azure-tools/typespec-ts@azure-tools/typespec-javaThe 🔴/🟢 markers match the benchmark comment's existing convention. I first tried real colored text via GitHub inline math, but it renders in MathJax's fonts rather than GitHub's, and it's a pattern almost no size bot uses —
preactjs/compressed-size-action,size-limit-action, Codecov, BundleMon and the Next.js bot all signal direction with emoji instead.compare.tsno longer runsmain()on import, so the rendering is covered by tests.