Repository navigation
feat: add flex support - #57
Open
Matthew Christopher (matthchr) wants to merge 2 commits into
Open
Matthew Christopher (matthchr) wants to merge 2 commits into
Matthew Christopher (matthchr) wants to merge 2 commits into
Conversation
Alex Leites (tallaxes)
approved these changes
Nov 10, 2026
Comment on lines
-18
to
+20
| `(?P<additiveFeatures>(?:[abcdeiflmnotspPr]+|C+|NP)?)_?(?:NDR_)?` + | ||
| `(?:(?P<acceleratorType>(?:xl_)?[A-Z]+[0-9]+[A-Z]*)_?)?` + | ||
| `(?P<additiveFeatures>(?:[abcdeiflmnotspPrux]+|C+|NP)?)` + |
There was a problem hiding this comment.
This also adds u and x, which we did not recognize before - which I think means we would start parsing/accepting sizes we have not in the past? This is likely fine, and an improvement - but probably worth calling out?
Comment on lines
+448
to
+450
| // Flex SKUs report only "Flex" in Size; their names carry the sizing details. | ||
| // TODO: Remove this workaround when Flex is removed. | ||
| if size == "Flex" { |
There was a problem hiding this comment.
Do we need to check for "Flex_Prime" here as well? (Not sure what the difference is ...)
Member
Author
There was a problem hiding this comment.
Good question let me check...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.