Repository navigation
refactor: small fixes to size parsing - #56
Merged
Matthew Christopher (matthchr) merged 1 commit intoNov 9, 2026
Merged
Conversation
Matthew Christopher (matthchr)
commented
Nov 9, 2026
Member
- Improve regex parsing readability with named capture groups.
- Add comments to VMSizeType with examples to showcase what each field does.
- Remove unused (never set) H100/MI300X fields. Use the AcceleratorType field instead.
Contributor
|
(AI-generated) Could we add a {
name: "Standard_NCC40ads_H100_v5",
size: "NCC40ads_H100_v5",
expectedVM: &VMSizeType{
Family: "N",
Subfamily: to.Ptr("CC"),
Cpus: "40",
AdditiveFeatures: []rune{'a', 'd', 's'},
AcceleratorType: to.Ptr("H100"),
ConfidentialChildCapability: false,
Version: "v5",
Series: "NCCads_v5",
},
}, |
* Improve regex parsing readability with named capture groups. * Add comments to VMSizeType with examples to showcase what each field does. * Remove unused (never set) H100/MI300X fields. Use the AcceleratorType field instead.
Matthew Christopher (matthchr)
force-pushed
the
matthchr/small-fixes
branch
from
November 9, 2026 20:43
9d4f6ed to
9a587e3
Compare
Maximiliano Uribe Falcon (MaximilianoUribe)
approved these changes
Nov 9, 2026
Maximiliano Uribe Falcon (MaximilianoUribe)
left a comment
Contributor
There was a problem hiding this comment.
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.