Skip to content

Update armcompute to v9 - #55

Merged
Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/compute-v9-update
Oct 22, 2026
Merged

Matthew Christopher (matthchr) merged 1 commit into
Azure:mainfrom
matthchr:matthchr/compute-v9-update

Conversation

@matthchr

Copy link
Copy Markdown
Member

This fixes the longstanding bug Azure/azure-sdk-for-go#23342

@xuexu6666

Copy link
Copy Markdown
Contributor

Code review

No issues found. Checked for bugs, Go idioms, prior-PR feedback, and code-comment/generated-file invariants.

Notes:

  • Import swaps are complete (grep -r armcompute/v8 is empty); go build/go vet/go test pass on the branch.
  • Test_SKU_UnmarshalZoneDetails correctly exercises the fix: it feeds the uppercase "Name" zoneDetails key from azure-sdk-for-go#23342 and asserts it now decodes via IsUltraSSDAvailableInAvailabilityZone.
  • v2/hack/generate_vmsize_testdata.go output is SDK-version-independent, so leaving v2/testdata unregenerated is correct.
  • Expect the usual Copilot nit on the go 1.25.0 patch directive in v2/go.mod — it's intentional (propagated from the azcore/armcompute deps) and was already resolved on bump armcompute v7 -> v8 in skewer/v2 #36.

@matthchr
Matthew Christopher (matthchr) merged commit 11fc19b into Azure:main Oct 22, 2026
2 checks passed
@matthchr
Matthew Christopher (matthchr) deleted the matthchr/compute-v9-update branch October 22, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants