Repository navigation
fix(helm): restrict certificate Secret write permissions - #681
Merged
jmclong (jmclong) merged 1 commit intoOct 26, 2026
Merged
jmclong (jmclong) merged 1 commit into
jmclong (jmclong) merged 1 commit into
Conversation
Hrishikesh Kashyap (Hrishikeshkashyap)
requested review from
a team,
Simon Croome (croomes),
jmclong (jmclong) and
Lana Andreasyan (landreasyan)
as code owners
October 26, 2026 14:02
Retain namespace-wide Secret reads for informer compatibility while limiting patch and update to the configured certificate Secret. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hrishikesh Kashyap (Hrishikeshkashyap)
force-pushed
the
fix/certificate-secret-write-rbac
branch
from
October 26, 2026 14:05
f5e296a to
f834e86
Compare
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped permission change preserves required certificate access, with reported live validation and no unresolved findings.
No open issues 🎉
What changed in this PR
This PR narrows the Helm chart’s certificate Secret write permissions while preserving the reads needed by the certificate controller.
Changes:
- Separates namespace-wide
get/list/watchpermissions from Secret write permissions. - Restricts
patch/updateto{{ .Values.name }}-webhook-cert. - Leaves namespace-wide Secret read exposure unchanged and explicitly out of scope.
| File | Description |
|---|---|
charts/latest/templates/certificate-rbac.yaml |
Splits Secret read and write rules, restricting writes to the configured certificate Secret. |
Review effort: Balanced
jmclong (jmclong)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
patchandupdateonly on{{ .Values.name }}-webhook-cert, matching the manager's configured certificate Secret.get/list/watchfor compatibility with the existing cert-controller informer.Validation
Scope
This reduces modification authority only. Namespace-wide Secret-content read exposure remains unresolved. Filtering informer requests upstream (open-policy-agent/cert-controller#590) is separate enabling work for a future read-RBAC restriction and is not required for this change.