Add feature PREVIEW_CAPTURE_LOGBACK_KEY_VALUE #47610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorzepowski
requested review from
a team,
harsimar,
jeanbisutti,
rajkumar-rangaraj,
ramthi,
trask and
xiang17
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new preview feature flag PREVIEW_CAPTURE_LOGBACK_KEY_VALUE to enable capturing key values from the SLF4J fluent API implemented by Logback. The change adds a new enum constant with ID 59 to track when this feature is enabled.
Key Changes:
- Added
PREVIEW_CAPTURE_LOGBACK_KEY_VALUE(59)enum constant to theFeatureenum in two identical files
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| sdk/monitor/azure-monitor-opentelemetry-exporter/src/main/java/com/azure/monitor/opentelemetry/exporter/implementation/statsbeat/Feature.java | Added new feature enum constant for capturing Logback key-value pairs |
| sdk/monitor/azure-monitor-opentelemetry-autoconfigure/src/main/java/com/azure/monitor/opentelemetry/autoconfigure/implementation/statsbeat/Feature.java | Added new feature enum constant for capturing Logback key-value pairs (duplicate of exporter implementation) |
github-actions
bot
added
Community Contribution
Contributor
|
Thank you for your contribution @dorzepowski! We will review the pull request and get back to you soon. |
Author
|
@microsoft-github-policy-service agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New preview feature for capturing key values from SLF4J fluent API implemented by Logback