VMware Module TSP Migration - #29973
Draft
JiaSeng-v wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 53a680b3-e007-4d4d-9fd2-448f9dd96b4f
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
|
Automated sensitive-information remediation ran on this pull request.
If a credential was exposed, rotate or revoke it immediately. Detected values are never copied into this comment. ✅ Keep the redaction · ❌ Dispute the redaction GitHub only supports a fixed reaction set, so 👍 represents ✅ and 👎 represents ❌. The bot-created reactions are only poll choices. Posted by agent-assist (autonomous bug-fix pipeline). |
azure-client-tools-agent
Bot
added
the
azure-client-tools-agent
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Az.VMware module’s generation workflow toward TypeSpec (TSP) by introducing TypeSpec emitter configuration and updating related generated artifacts (module metadata, solution/project wiring, and reference docs/help).
Changes:
- Added TypeSpec (TSP) configuration files for the VMware AutoRest/TypeSpec generation pipeline (
tspconfig.yaml,tsp-location.yaml). - Updated module metadata and build wiring (solution project GUID, module manifest dependency, assembly/generation metadata, changelog).
- Regenerated/updated cmdlet help and reference documentation markdown files.
Reviewed changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated 23 comments.
Show a summary per file
| File | Description |
|---|---|
| src/VMware/VMware/help/Update-AzVMwarePrivateCloud.md | Help text updates; contains new spacing/grammar regressions and example wording changes. |
| src/VMware/VMware/help/Update-AzVMwareGlobalReachConnection.md | Help text update; contains a missing-space typo in parameter description. |
| src/VMware/VMware/help/Update-AzVMwareDatastore.md | Help text update; contains a missing-space typo in parameter description. |
| src/VMware/VMware/help/Update-AzVMwareCluster.md | Help text update; example wording changed (“Ex - P3.”). |
| src/VMware/VMware/help/Test-AzVMwareServiceComponentAvailability.md | Help text update; -Location description became less specific/ambiguous. |
| src/VMware/VMware/help/Test-AzVMwareLocationTrialAvailability.md | Help text update; -Location description became ambiguous; example wording changed. |
| src/VMware/VMware/help/Test-AzVMwareLocationQuotaAvailability.md | Help text update; -Location description became less specific/ambiguous. |
| src/VMware/VMware/help/New-AzVMwareGlobalReachConnection.md | Help text update; contains a missing-space typo in parameter description. |
| src/VMware/VMware/help/New-AzVMwareDatastore.md | Help text update; contains a missing-space typo in parameter description. |
| src/VMware/VMware/help/New-AzVMwareCluster.md | Help text update; example wording changed (“Ex - P3.”). |
| src/VMware/VMware/ChangeLog.md | Adds an “internal code generation” entry; currently conflicts with other “Upcoming Release” user-facing content. |
| src/VMware/VMware/Az.VMware.psd1 | Updates required Az.Accounts dependency version and generation timestamp. |
| src/VMware/VMware.sln | Updates the Az.VMware project GUID wiring in the solution file. |
| src/VMware/VMware.Autorest/tspconfig.yaml | New TypeSpec emitter configuration and directives for cmdlet shaping. |
| src/VMware/VMware.Autorest/tsp-location.yaml | New spec location definition; uses backslashes that are inconsistent with other modules. |
| src/VMware/VMware.Autorest/README.md | Removes prior generation docs; remaining text still references AutoRest and needs to reflect TSP migration. |
| src/VMware/VMware.Autorest/Properties/AssemblyInfo.cs | Updates assembly metadata/versioning consistent with regenerated code artifacts. |
| src/VMware/VMware.Autorest/generate-info.json | Regeneration metadata update. |
| src/VMware/VMware.Autorest/docs/Update-AzVMwarePrivateCloud.md | Reference doc update; example wording changed (“Ex - P3.”). |
| src/VMware/VMware.Autorest/docs/Update-AzVMwareCluster.md | Reference doc update; example wording changed (“Ex - P3.”). |
| src/VMware/VMware.Autorest/docs/Test-AzVMwareServiceComponentAvailability.md | Reference doc update; -Location description became less specific/ambiguous. |
| src/VMware/VMware.Autorest/docs/Test-AzVMwareLocationTrialAvailability.md | Reference doc update; -Location description became ambiguous; example wording changed. |
| src/VMware/VMware.Autorest/docs/Test-AzVMwareLocationQuotaAvailability.md | Reference doc update; -Location description became less specific/ambiguous. |
| src/VMware/VMware.Autorest/docs/New-AzVMwareCluster.md | Reference doc update; example wording changed (“Ex - P3.”). |
| src/VMware/VMware.Autorest/docs/Az.VMware.md | Module doc metadata update (module GUID). |
| The name of the SKU. | ||
| E.g. | ||
| P3. | ||
| Ex - P3. |
Comment on lines
+154
to
155
| Networks must beunique and non-overlapping across VNet in your subscription, on-premise, andthis privateCloud networkBlock attribute. | ||
| Make sure the CIDR format conforms to(A.B.C.D/X). |
Comment on lines
+320
to
+321
| The block of addresses should be unique across VNet in your subscription aswell as on-premise. | ||
| Make sure the CIDR format is conformed to (A.B.C.D/X) whereA,B,C,D are between 0 and 255, and X is between 0 and 22 |
| The name of the SKU. | ||
| E.g. | ||
| P3. | ||
| Ex - P3. |
| ### -ExpressRouteId | ||
| The ID of the Private Cloud's ExpressRoute Circuit that is participating in the global reach connection | ||
| The ID of the Private Cloud's ExpressRoute Circuit that is participating in theglobal reach connection |
| ### -Location | ||
| The name of the Azure region. | ||
| A location in a subscription |
| The name of the SKU. | ||
| E.g. | ||
| P3. | ||
| Ex - P3. |
| - Additional information about change #1 | ||
| --> | ||
| ## Upcoming Release | ||
| * Internal code generation updated. No user-facing changes in this release. |
| @@ -0,0 +1,3 @@ | |||
| directory: specification\vmware\resource-manager\Microsoft.AVS\AVS | |||
Comment on lines
22
to
24
| ## Development | ||
| For information on how to develop for `Az.VMware`, see [how-to.md](how-to.md). | ||
| <!-- endregion --> |
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot <[REDACTED:email_address]>
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.