Skip to content

{Packaging} Build wheels with python -m build instead of python setup.py #33941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aryasadeghi1 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

{Packaging} Build wheels with python -m build instead of python setup.py #33941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions scripts/ci/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,11 @@ title 'Build Azure CLI and its command modules'
for setup_file in $(find src -name 'setup.py'); do
pushd $(dirname ${setup_file}) >/dev/null
echo "Building module at $(pwd) ..."
python setup.py -q bdist_wheel -d $output_dir
python setup.py -q sdist -d $sdist_dir
# --no-isolation builds against the environment prepared by the caller rather than
# provisioning a fresh one, which keeps the caller's setuptools pin in force and
# avoids requiring outbound network access inside the packaging test containers.
python -m build --wheel --no-isolation --outdir $output_dir
python -m build --sdist --no-isolation --outdir $sdist_dir
Comment on lines +55 to +59
popd >/dev/null
done

Expand Down Expand Up @@ -187,8 +190,8 @@ Azure CLI Test Cases
EOL

pushd $testsrc_dir >/dev/null
python setup.py -q bdist_wheel -d $output_dir
python setup.py -q sdist -d $sdist_dir
python -m build --wheel --no-isolation --outdir $output_dir
python -m build --sdist --no-isolation --outdir $sdist_dir
popd >/dev/null

##############################################
Expand Down
3 changes: 2 additions & 1 deletion scripts/release/debian/test_deb_in_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ time az self-test
time az --version

cd /azure-cli/
/opt/az/bin/python3 -m pip install wheel
# `build` is the PEP 517 frontend used by scripts/ci/build.sh.
/opt/az/bin/python3 -m pip install wheel build
ln -sf /opt/az/bin/python3 /usr/bin/python
./scripts/ci/build.sh

Expand Down
3 changes: 2 additions & 1 deletion scripts/release/homebrew/test_homebrew_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ AZ_BASE=/usr/local/Cellar/azure-cli/$CLI_VERSION/libexec
export PATH=$AZ_BASE/bin:$PATH
export OBJC_DISABLE_INITIALIZE_FORK_SAFETY=YES
echo $PATH
pip install wheel
# `build` is the PEP 517 frontend used by scripts/ci/build.sh.
pip install wheel build
./scripts/ci/build.sh
pip install pytest --prefix $AZ_BASE
pip install pytest-xdist --prefix $AZ_BASE
Expand Down
6 changes: 4 additions & 2 deletions scripts/release/rpm/test_azurelinux_in_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ time az self-test
time az --version

cd /azure-cli/
# Cap setuptools<81: 81 removes setup.py --dry-run and changes distutils command signatures (82 removes pkg_resources); build.sh relies on setup.py.
python -m pip install --upgrade "setuptools<81"
# Cap setuptools<81: 81 removes setup.py --dry-run and changes distutils command signatures (82 removes pkg_resources).
# scripts/ci/build.sh builds with `python -m build --no-isolation`, so this pin is the setuptools the build uses.
# `build` is the PEP 517 frontend that script invokes.
python -m pip install --upgrade "setuptools<81" build
Comment on lines +18 to +20
./scripts/ci/build.sh

# From Fedora36, when using `pip install --prefix` with root privileges, the package is installed into `{prefix}/local/lib`.
Expand Down
6 changes: 4 additions & 2 deletions scripts/release/rpm/test_rpm_in_docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,10 @@ time az self-test
time az --version

cd /azure-cli/
# Cap setuptools<81: 81 removes setup.py --dry-run and changes distutils command signatures (82 removes pkg_resources); build.sh relies on setup.py.
python -m pip install --upgrade pip "setuptools<81"
# Cap setuptools<81: 81 removes setup.py --dry-run and changes distutils command signatures (82 removes pkg_resources).
# scripts/ci/build.sh builds with `python -m build --no-isolation`, so this pin is the setuptools the build uses.
# `build` is the PEP 517 frontend that script invokes.
Comment on lines +18 to +20
python -m pip install --upgrade pip "setuptools<81" build
./scripts/ci/build.sh

# From Fedora36, when using `pip install --prefix` with root privileges, the package is installed into `{prefix}/local/lib`.
Expand Down
Loading