Fix misleading WSLInterop browser login errors - #33932
Fix misleading WSLInterop browser login errors#33932Aditya Pujara (a0x1ab) with Copilot wants to merge 10 commits into
Conversation
|
Hi Copilot, |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Co-authored-by: a0x1ab <59631311+a0x1ab@users.noreply.github.com>
Live test skipped⏭️ Skipping the live test for this revision because the only test file(s) changed are These |
There was a problem hiding this comment.
Automated Review Summary — PR #33932
Live test: Skipped — the only changed test file is an azure-cli-core unit test, which is not runnable via azdev test --live. Not a gap in coverage; unit tests are exercised by upstream CI instead.
CI checks: ✅ All passed (1/1 completed, 0 failed, 0 pending).
No outstanding issues found. This PR looks ready for human maintainer review/merge.
|
🔔 Routing this PR to @Azure/act-identity-squad. |
|
az login |
Related command
az loginDescription
On newer WSL environments, interop can be enabled through entries such as
WSLInterop-late, while older browser-launch fallbacks still probe/proc/sys/fs/binfmt_misc/WSLInteropand emit misleading “WSL Interoperability is disabled” errors.az logincan still succeed, but the error output incorrectly suggests WSL is misconfigured.WSL interop detection
WSLInterop*binfmt entries, includingWSLInterop-late.WSL_INTEROPwhen binfmt metadata is unavailable.Interactive login browser launch
Safety and concurrency
webbrowser.openpatching during interactive login.Testing Guide
Focused regression coverage was added for:
WSLInterop-latedetectionaz logininteractive auth-code path using the WSL browser wrapperHistory Notes
[Profile]
az login: Fix misleading WSLInterop disabled errors during browser login on WSLThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.