{Network} az network vnet create: Remove unsupported summarized-gateway-prefixes with ipam-pool-prefix-allocations reference from help text - #33930
Conversation
|
Hi Jian Hui (@huiii99), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
There was a problem hiding this comment.
Pull request overview
This PR updates the autogenerated AAZ help text for az network vnet create and az network vnet update to remove examples that combine --summarized-gateway-prefixes with ipam-pool-prefix-allocations, since that scenario is not supported for public use. This aligns the CLI help output with current command behavior and avoids directing users toward a non-functional configuration (per #33923).
Changes:
- Removed the
--summarized-gateway-prefixes ipam-pool-prefix-allocations=...example fromaz network vnet createhelp. - Removed the
--summarized-gateway-prefixes ipam-pool-prefix-allocations=...example fromaz network vnet updatehelp.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/vnet/_create.py | Removes the unsupported summarized-gateway-prefixes + IPAM example from the command docstring examples. |
| src/azure-cli/azure/cli/command_modules/network/aaz/latest/network/vnet/_update.py | Removes the unsupported summarized-gateway-prefixes + IPAM example from the command docstring examples. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
@Azure/act-quality-productivity-squad Aditya Pujara (@a0x1ab) it looks like #33926 and #33930 were created independently for #33923. #33926 is a downstream-only edit, while #33930 is linked to the source-of-truth change in Azure/aaz#1068.
Shall we keep #33930 as the canonical downstream PR and close #33926 as a duplicate.
Could Q&P confirm which PR should be retained before either is merged?
Live test skipped⏭️ Skipping the live test for this revision because no new test file was added ( The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. This is informational — a regression test is encouraged where it makes sense, but not required. If a test file is added in a later commit, the live test will run automatically. |
There was a problem hiding this comment.
Automated Review Summary
CI: ✅ All 64 checks passed, no pending or failed runs.
Live test: No runnable test files changed by this PR (help-text only change), so the live-test tester step was skipped.
This PR looks good from an automated standpoint — no code paths or test files affected, only help text corrections. No further action needed from the agent.
|
🔔 Routing this PR to @Azure/act-quality-productivity-squad. |
the reason behind is somehow similar as https://github.com/Azure/CLIPS/issues/652#issuecomment-5350008102. will handle them later. |
az network vnet create: Remove unsupported summarized-gateway-prefixes with ipam-pool-prefix-allocations reference from help textaz network vnet create: Remove unsupported summarized-gateway-prefixes with ipam-pool-prefix-allocations reference from help text
🤖 PR Validation — ️✔️ All clear
Related command
az network vnet createaz network vnet updateDescription
The help for
az network vnet createandaz network vnet updateincluded examples combining--summarized-gateway-prefixeswithipam-pool-prefix-allocations, but this combination is not currently supported for public use.Remove the unsupported examples to avoid directing users to an unavailable scenario. The supported
address-prefixesexamples remain unchanged.Fixes #33923
aaz Azure/aaz#1068
Testing Guide
az network vnet create --helpaz network vnet update --helpHistory Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.