Skip to content

[ACR] Warn before overwriting an existing cache rule #33911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mabel Egba (mabelegba) wants to merge 6 commits into from
Closed

[ACR] Warn before overwriting an existing cache rule #33911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80f4ba4
[ACR] Warn before overwriting an existing cache rule
Aug 17, 2026
17a1a2e
add warning only when overwriting a cache rule
Aug 17, 2026
20c97ce
Group ACR cache imports
Aug 18, 2026
27e4aaa
[ACR] Update cache rule test recordings
Aug 18, 2026
87ece07
[ACR] Avoid cache rule read preflight
Aug 18, 2026
f8eec71
remove unused import
Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/azure-cli/azure/cli/command_modules/acr/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
IdentityProperties,
UserIdentityProperties
)
from knack.log import get_logger

logger = get_logger(__name__)


def acr_cache_show(cmd,
Expand Down Expand Up @@ -66,6 +69,7 @@ def acr_cache_create(cmd,
identity=None):

rg = get_resource_group_name_by_registry_name(cmd.cli_ctx, registry_name, resource_group_name)
logger.warning("If cache rule '%s' already exists, it will be overwritten.", name)

# Handle credential set
if cred_set:
Expand Down
21 changes: 21 additions & 0 deletions src/azure-cli/azure/cli/command_modules/acr/tests/latest/test_acr_commands_mock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
)
from azure.cli.command_modules.acr._docker_utils import ResourceNotFound
from azure.cli.command_modules.acr._constants import ACR_AUDIENCE_RESOURCE_NAME
from azure.cli.command_modules.acr.cache import acr_cache_create
from azure.cli.core.mock import DummyCli


Expand All @@ -64,6 +65,26 @@

class AcrMockCommandsTests(unittest.TestCase):

@mock.patch('azure.cli.command_modules.acr.cache.logger.warning')
@mock.patch('azure.cli.command_modules.acr.cache.get_resource_group_name_by_registry_name')
def test_cache_create_warns_that_existing_rule_is_overwritten(
self, mock_get_resource_group, mock_warning):
cmd = self._setup_cmd()
client = mock.MagicMock()
mock_get_resource_group.return_value = 'testresourcegroup'

acr_cache_create(
cmd=cmd,
client=client,
registry_name='testregistry',
name='testcache',
source_repo='mcr.microsoft.com/mcr/hello-world',
target_repo='hello-world')

mock_warning.assert_called_once_with(

@luisdlp Luis Dieguez (luisdlp) Aug 18, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we testing both outcomes, ie. if the rule already exists and if it doesn't exist? How does the test guarantee that the rule exists?

"If cache rule '%s' already exists, it will be overwritten.",
'testcache')

@mock.patch('azure.cli.command_modules.acr.repository.get_access_credentials', autospec=True)
@mock.patch('requests.request', autospec=True)
def test_repository_list(self, mock_requests_get, mock_get_access_credentials):
Expand Down
Loading