{App Service} Support Isolated v4 plan SKUs - #33892
Open
Jordan Selig (seligj95) wants to merge 4 commits into
Open
{App Service} Support Isolated v4 plan SKUs#33892Jordan Selig (seligj95) wants to merge 4 commits into
Jordan Selig (seligj95) wants to merge 4 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Azure CLI support for App Service Environment (ASE) Isolated v4 plan SKUs by recognizing the new SKU names and mapping them to the appropriate tier used in plan creation/update flows.
Changes:
- Introduces
ISOLATED_V4_SKUSand uses it to mapI*V4/I*MV4SKUs to theIsolatedV4tier. - Extends App Service plan SKU validation and parameter enums to accept Isolated v4 SKUs and treat them as ASE-only.
- Adds unit tests covering Isolated v4 tier mapping and ASE requirement, and updates release history.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/HISTORY.rst | Documents the new Isolated v4 SKU support in release history. |
| src/azure-cli/azure/cli/command_modules/appservice/utils.py | Maps Isolated v4 SKU names to the IsolatedV4 tier via get_sku_tier. |
| src/azure-cli/azure/cli/command_modules/appservice/_validators.py | Treats Isolated v4 SKUs as ASE-only and allows IsolatedV4 for zone redundancy gating. |
| src/azure-cli/azure/cli/command_modules/appservice/_params.py | Extends the --sku enum/help to include Isolated v4 SKUs. |
| src/azure-cli/azure/cli/command_modules/appservice/_constants.py | Adds the centralized ISOLATED_V4_SKUS list. |
| src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_appservice_validators_thru_mock.py | Adds regression tests for Isolated v4 tier mapping and ASE requirement. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Collaborator
|
App Service |
Aditya Pujara (a0x1ab)
added
the
Azure Client Tools Agent Requested
Contributor
Live test results —
|
Member
|
@Azure/act-observability-squad can we please get a review on this PR related to App Service. Thank you! |
![azure-client-tools-agent[bot]](https://avatars.githubusercontent.com/in/4205534?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Automated Review Summary — All Green ✅
PR: {App Service} Support Isolated v4 plan SKUs
- CI checks: 53/53 passed, 0 failed, 0 pending
- Live test (
azdev test --live): completed successfully (workflow run 32219768915)
No outstanding issues found. This PR looks ready from an automation standpoint.
azure-client-tools-agent
Bot
added
azure-client-tools-agent
Contributor
|
🔔 Routing this PR to @Azure/act-observability-squad. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
Description
Add Azure CLI support for the Isolated v4 App Service Environment SKUs documented at https://learn.microsoft.com/azure/app-service/environment/app-service-configure-isolated-v4-tier:
I1V4-I6V4andI1MV4-I5MV4foraz appservice plan create/updateIsolatedV4ARM tierTesting
python3 -m pytest src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_appservice_validators_thru_mock.py -qpython3 -m pytest src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_commands_thru_mock.py::TestCreateAppServicePlanDefaults -qpython3 -m flake8on all changed Python filesaz appservice plan create ... --sku I1V4invocation proceeds past argument and SKU validation to ASE lookup