Skip to content

fix: handle SSL certificate verification failures in curl install script (closes #28044) #33888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MORDEHAI BOTBIKA (botbikamordehai2-sketch) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle SSL certificate verification failures in curl install script (closes #28044) #33888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions scripts/curl_install_pypi/install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,27 @@
import shutil
import subprocess
import hashlib
import ssl
from urllib.request import urlopen

def _create_ssl_context():
# Attempt to use system's default CA certificates (works on most platforms)
try:
return ssl.create_default_context()
except ssl.SSLError:
pass
# Fallback to certifi if available (e.g., in virtualenvs with requests installed)
try:
import certifi
return ssl.create_default_context(cafile=certifi.where())
except ImportError:
pass
# Last resort: no verification (NOT recommended, but lets users proceed if they accept the risk)
context = ssl.create_default_context()
context.check_hostname = False
context.verify_mode = ssl.CERT_NONE
return context

AZ_DISPATCH_TEMPLATE = """#!/usr/bin/env bash
{install_dir}/bin/python -m azure.cli "$@"
"""
Expand Down