Bump cryptography from 48.0.1 to 50.0.0 in /src/azure-cli - #33845
Bump cryptography from 48.0.1 to 50.0.0 in /src/azure-cli#33845dependabot[bot] wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Thank you for your contribution Dependabot (@dependabot)[bot]! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
This PR updates the pinned cryptography dependency version across platform-specific Azure CLI Python 3 requirements files.
Changes:
- Bump
cryptographyfrom46.0.7to50.0.0in Windows requirements - Bump
cryptographyfrom46.0.7to50.0.0in Linux requirements - Bump
cryptographyfrom46.0.7to50.0.0in macOS (Darwin) requirements
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli/requirements.py3.windows.txt | Updates pinned cryptography version for Windows runtime deps |
| src/azure-cli/requirements.py3.Linux.txt | Updates pinned cryptography version for Linux runtime deps |
| src/azure-cli/requirements.py3.Darwin.txt | Updates pinned cryptography version for macOS runtime deps |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
bump cryptography |
Live test skipped⏭️ Skipping the live test for this revision because no new test file was added ( The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. This is informational — a regression test is encouraged where it makes sense, but not required. If a test file is added in a later commit, the live test will run automatically. |
There was a problem hiding this comment.
Automated CI Review — Failing Checks
This PR (cryptography 46.0.7 → 50.0.0) currently has 68 of 86 checks failing, spanning nearly every category:
- Lint/style:
azdev-style,azdev-linter,Check CLI Style,Check CLI Linter - Builds: Windows MSI/ZIP (x86/x64), Homebrew Formula, macOS (Intel/ARM64), Debian/RPM packages across Bookworm/Bullseye/Jammy/Noble/RHEL/Azure Linux (AMD64/ARM64)
- Test suites:
Azure.azure-climain build,Azure.azure-cli Full Test(all Python 3.12/3.14 profile-latest instances), Unit Tests for Core and Telemetry (Python 3.12/3.14) - Other:
Codegen Coverage,PerformanceCheck(Python 3.12/3.14),Verify latest index assets,Check License, History, and DocMap,Verify requirements.*.txt(Windows/Linux/Darwin)
This breadth of failure strongly suggests the cryptography 50.0.0 upgrade introduces a breaking change (e.g., API removal/behavior change) that affects core CLI functionality, packaging, and test collection — not an isolated/flaky failure. A maintainer should review whether:
cryptography50.0.0 requires compatible pinning/adjustments elsewhere inazure-clibefore this bump can merge, or- This bump needs to wait until a smaller/patch version is available, or downstream consumers are updated first.
Representative failing runs:
- Build: https://github.com/Azure/azure-cli/runs/92167492473
- Full Test: https://github.com/Azure/azure-cli/runs/92162586739
- Style: https://github.com/Azure/azure-cli/actions/runs/32217616414/job/95961966436
- Linter: https://github.com/Azure/azure-cli/actions/runs/32217616255/job/95961965707
Leaving this for maintainer/human review given the scope of the breakage.
Bumps [cryptography](https://github.com/pyca/cryptography) from 48.0.1 to 50.0.0. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@48.0.1...50.0.0) --- updated-dependencies: - dependency-name: cryptography dependency-version: 50.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
b222f0b to
613e7b8
Compare
Live test skipped⏭️ Skipping the live test for this revision because no changed test file was found ( The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. A skipped live test is not a passing test result. The Agent review separately checks whether the affected command module includes focused regression tests or updated recordings. If a test file is changed in a later commit, the live test will run automatically. |
There was a problem hiding this comment.
Automated CI Review — Failing Checks
The live-test dispatch was skipped (this PR changes no runnable test files matching tests/**/test_*.py), and CI shows 66 of 78 checks failing, including:
Azure.azure-cli(main build) — 42 errors: https://dev.azure.com/azclitools/5147fa83-336e-44ef-bbe0-c86b8ae86cbb/_build/results?buildId=340320Azure.azure-cli Full Test— 16 errors: https://dev.azure.com/azclitools/5147fa83-336e-44ef-bbe0-c86b8ae86cbb/_build/results?buildId=340321azdev-linter(x2),azdev-style(x2) — failing- All downstream package builds (Deb/Rpm/Homebrew/Windows MSI/ZIP/macOS) and Automation Full Test instances are failing as a consequence of the core build failure.
Action needed: The primary build failure must be fixed first — please inspect the 42 build errors in the linked Azure DevOps build (buildId=340320), as all other failures appear to cascade from it. Push a fix commit and the downstream checks should re-run automatically.
Bumps cryptography from 48.0.1 to 50.0.0.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
dcb7050Prepare for 50.0.0 release (#15372)53fccd9Don't leak how PKCS#7 encryptedKey decryption failed (#15369)d472f97Addfrom __future__ import annotationsto all src/ Python files (#15371)908773dBump downstream dependencies in CI (#15368)2cc07ccBump BoringSSL, OpenSSL, AWS-LC in CI (#15367)c94ede9chore(deps): bump ruff from 0.16.0 to 0.16.1 (#15366)67a8308chore(deps): bump virtualenv from 21.7.0 to 21.7.1 (#15365)95018ffRelease the GIL in one-shot AEAD encrypt/decrypt (#15361)6954733Release the GIL during DH and DSA parameter generation (#15364)6893b94Import _serialization instead of serialization in x509/extensions (#15363)