[Container App Job] Fix crash for containerapp job update --no-wait

[Christian Mäder (cimnine)]

🤖 PR Validation — ️✔️ All clear

Breaking Changes	Tests
️✔️ None	️✔️ 130/130

Related command

az containerapp job update \
            --name ${{ job.Name }} \
            --resource-group ${{ parameters.ResourceGroupName }} \
            --image ${{ parameters.ContainerRegistryName }}/${{ job.Repository }}:${{ parameters.ImageTag }} \
            --no-wait

Description
It fixes the following crash:

2026-07-28T12:18:42.1518490Z ##[section]Starting: containerappjob:update caj-csx-t-zh-1-cleanup-files
2026-07-28T12:18:42.1523350Z ==============================================================================
2026-07-28T12:18:42.1523463Z Task         : Bash
2026-07-28T12:18:42.1523517Z Description  : Run a Bash script on macOS, Linux, or Windows
2026-07-28T12:18:42.1523601Z Version      : 3.274.1
2026-07-28T12:18:42.1523659Z Author       : Microsoft Corporation
2026-07-28T12:18:42.1523725Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/bash
2026-07-28T12:18:42.1523822Z ==============================================================================
2026-07-28T12:18:42.2436757Z Generating script.
2026-07-28T12:18:42.2446049Z ========================== Starting Command Output ===========================
2026-07-28T12:18:42.2453901Z [command]/usr/bin/bash /azp/_temp/6c0482c6-5b76-4f4c-9990-d90ee6a19cef.sh
2026-07-28T12:18:45.7184805Z ERROR: The command failed with an unexpected error. Here is the traceback:
2026-07-28T12:18:45.7212321Z ERROR: argument of type 'NoneType' is not iterable
2026-07-28T12:18:45.7212652Z Traceback (most recent call last):
2026-07-28T12:18:45.7212911Z   File "/opt/az/lib/python3.13/site-packages/knack/cli.py", line 233, in invoke
2026-07-28T12:18:45.7213156Z     cmd_result = self.invocation.execute(args)
2026-07-28T12:18:45.7213422Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/__init__.py", line 666, in execute
2026-07-28T12:18:45.7213669Z     raise ex
2026-07-28T12:18:45.7213939Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/__init__.py", line 734, in _run_jobs_serially
2026-07-28T12:18:45.7214241Z     results.append(self._run_job(expanded_arg, cmd_copy))
2026-07-28T12:18:45.7214471Z                    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
2026-07-28T12:18:45.7214735Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/__init__.py", line 726, in _run_job
2026-07-28T12:18:45.7215001Z     return cmd_copy.exception_handler(ex)
2026-07-28T12:18:45.7215225Z            ~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^
2026-07-28T12:18:45.7215722Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/command_modules/containerapp/_client_factory.py", line 28, in _polish_bad_errors
2026-07-28T12:18:45.7216001Z     raise ex
2026-07-28T12:18:45.7216241Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/__init__.py", line 703, in _run_job
2026-07-28T12:18:45.7216492Z     result = cmd_copy(params)
2026-07-28T12:18:45.7216742Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/__init__.py", line 336, in __call__
2026-07-28T12:18:45.7217025Z     return self.handler(*args, **kwargs)
2026-07-28T12:18:45.7217243Z            ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
2026-07-28T12:18:45.7217519Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/core/commands/command_operation.py", line 120, in handler
2026-07-28T12:18:45.7217819Z     return op(**command_args)
2026-07-28T12:18:45.7218076Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/command_modules/containerapp/custom.py", line 1084, in update_containerappsjob
2026-07-28T12:18:45.7218294Z     return update_containerappsjob_logic(cmd=cmd,
2026-07-28T12:18:45.7218447Z                                          name=name,
2026-07-28T12:18:45.7218695Z     ...<25 lines>...
2026-07-28T12:18:45.7218934Z                                          max_executions=max_executions,
2026-07-28T12:18:45.7219156Z                                          no_wait=no_wait)
2026-07-28T12:18:45.7219452Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/command_modules/containerapp/custom.py", line 1449, in update_containerappsjob_logic
2026-07-28T12:18:45.7219765Z     handle_raw_exception(e)
2026-07-28T12:18:45.7219987Z     ~~~~~~~~~~~~~~~~~~~~^^^
2026-07-28T12:18:45.7220297Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/command_modules/containerapp/_client_factory.py", line 63, in handle_raw_exception
2026-07-28T12:18:45.7220826Z     raise e
2026-07-28T12:18:45.7221140Z   File "/opt/az/lib/python3.13/site-packages/azure/cli/command_modules/containerapp/custom.py", line 1444, in update_containerappsjob_logic
2026-07-28T12:18:45.7221703Z     if "properties" in r and "provisioningState" in r["properties"] and r["properties"]["provisioningState"].lower() == "waiting" and not no_wait:
2026-07-28T12:18:45.7222000Z        ^^^^^^^^^^^^^^^^^
2026-07-28T12:18:45.7222227Z TypeError: argument of type 'NoneType' is not iterable
2026-07-28T12:18:45.7237609Z To check existing issues, please visit: https://github.com/Azure/azure-cli/issues
2026-07-28T12:18:45.8265973Z 
2026-07-28T12:18:45.8303855Z ##[error]Bash exited with code '1'.
2026-07-28T12:18:45.8337872Z ##[section]Finishing: containerappjob:update caj-csx-t-zh-1-cleanup-files

This patch was created with the help of Claude Code:

This confirms the fix is exactly what az containerapp update (the non-job command) already does — the two are structurally identical, and the job version was the outlier.

ContainerAppClient.update (_clients.py:159-160) and ContainerAppsJobClient.update (_clients.py:895-896) both do the same thing: return None when no_wait=True.

 if no_wait:
     return

update_containerapp_logic (regular containerapp update), custom.py:710-715:

 r = ContainerAppClient.update(
     cmd=cmd, resource_group_name=resource_group_name, name=name, container_app_envelope=new_containerapp, no_wait=no_wait)

 if not no_wait and "properties" in r and "provisioningState" in r["properties"] and r["properties"]["provisioningState"].lower() == "waiting":

not no_wait is checked first, so when no_wait=True and r is None, the and chain short-circuits before ever touching r["properties"]. Safe.

update_containerappsjob_logic (containerapp job update), custom.py:1442-1446 — before my fix:

r = ContainerAppsJobClient.update(
    cmd=cmd, resource_group_name=resource_group_name, name=name, containerapp_job_envelope=new_containerappsjob, no_wait=no_wait)

if "properties" in r and "provisioningState" in r["properties"] and r["properties"]["provisioningState"].lower() == "waiting" and not no_wait:

Same None-on-no_wait return, but not no_wait was placed last. With no_wait=True, Python still evaluates "properties" in r on r = None before ever reaching not no_wait — hence TypeError: argument of type 'NoneType' is not iterable, exactly matching the pipeline traceback.

My fix moves not no_wait to the front, at line 1446, making the job command's check byte-for-byte identical in structure to the container-app command's (and to the two other matching sites at custom.py:249 and custom.py:1527). All four now read:

if not no_wait and "properties" in r and "provisioningState" in r["properties"] and r["properties"]["provisioningState"].lower() == "waiting":

So the job path now behaves the same as the already-correct app path under --no-wait.

Testing Guide

This will not crash anymore:

az containerapp job update \
            --name ${{ job.Name }} \
            --resource-group ${{ parameters.ResourceGroupName }} \
            --image ${{ parameters.ContainerRegistryName }}/${{ job.Repository }}:${{ parameters.ImageTag }} \
            --no-wait

History Notes

---

This checklist is used to make sure that common guidelines for a pull request are followed.

• The PR title and description has followed the guideline in Submitting Pull Requests.

• I adhere to the Command Guidelines.

• I adhere to the Error Handling Guidelines.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[azure-pipelines]

Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

[Christian Mäder (cimnine)]

@microsoft-github-policy-service agree company="nxt Engineering GmbH"

[Copilot]

Pull request overview

Fixes a TypeError: argument of type 'NoneType' is not iterable crash in az containerapp job update --no-wait by ensuring the provisioning-state warning check short-circuits before evaluating the response object when no_wait=True.

Changes:

• Reorders the post-update provisioningState == "waiting" check in update_containerappsjob_logic to guard on not no_wait first.
• Adds unit tests to ensure both containerapp update and containerapp job update do not crash under --no-wait and still return the update response when no_wait=False.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/azure-cli/azure/cli/command_modules/containerapp/custom.py	Prevents None response from being evaluated in the provisioning-state check when --no-wait is set.
src/azure-cli/azure/cli/command_modules/containerapp/tests/latest/test_containerapp_update_provisioning_state.py	Adds regression tests covering no_wait=True (no crash) and no_wait=False (returns response) for both app and job update paths.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Yong Zhang (yonzhan)]

Container App Job

[Yabo Hu (VeryEarly)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[Yabo Hu (VeryEarly)]

Hi Christian Mäder (@cimnine) , thanks for your contribution, please find what license headers used by other files and replace yours in the new test case.

[Yabo Hu (VeryEarly)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[Christian Mäder (cimnine)]

Hi Christian Mäder (@cimnine) , thanks for your contribution, please find what license headers used by other files and replace yours in the new test case.

Why?

[Christian Mäder (cimnine)]

Hi Christian Mäder (@cimnine) , thanks for your contribution, please find what license headers used by other files and replace yours in the new test case.

Yabo Hu (@VeryEarly) I removed the offending file. You can use an agent to recreate the tests easily. But just writing another copyright header is incompatible with Swiss copyright law, AFAIK. As IANAL, this is the best compromise I could come up with.

[azure-client-tools-agent]

Live test skipped

⏭️ Skipping the live test for this revision because no new test file was added (tests/**/test_*.py).

The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. This is informational — a regression test is encouraged where it makes sense, but not required. If a test file is added in a later commit, the live test will run automatically.

[azure-client-tools-agent]

Automated CI Review — All Checks Passed ✅

All checks are green for this PR (fixes a crash in containerapp job update --no-wait). No further automated action needed here.

[Cooper Cox (coopercox-ms)]

/azp run

[azure-pipelines]

Azure Pipelines:
Successfully started running 3 pipeline(s).

[microsoft-github-policy-service]

🔔 Routing this PR to @Azure/act-observability-squad.