fix: use system SSL context in install.py to avoid self-signed certificate errors (closes #28044) - #33790
Conversation
…icate errors (closes Azure#28044)
|
Hi MORDEHAI BOTBIKA (@botbikamordehai2-sketch), |
|
Hi MORDEHAI BOTBIKA (@botbikamordehai2-sketch), |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
MORDEHAI BOTBIKA (@botbikamordehai2-sketch) please reply comments from microsoft-github-policy-service |
| print_status("Downloaded virtualenv package to {}.".format(download_location)) | ||
| if is_valid_sha256sum(download_location, VIRTUALENV_ARCHIVE_SHA256): | ||
| print_status("Checksum of {} OK.".format(download_location)) | ||
| print_status("Checksum of {} OK.".format(download_location))ad_location)) |
There was a problem hiding this comment.
what is ad_location?
|
Is this a duplicate of #30468 ? |
Live test skipped⏭️ Skipping the live test for this revision because no new test file was added ( The live-test pipeline runs only the test files a PR changes, so there is nothing to execute for this commit. This is informational — a regression test is encouraged where it makes sense, but not required. If a test file is added in a later commit, the live test will run automatically. |
There was a problem hiding this comment.
Automated Review Summary — PR #33790
Live test: Skipped — this PR changes no test files (tests/**/test_*.py), so there is nothing for the live-test workflow to run against azdev test.
CI checks: 1 check (license/cla) has been stuck in queued for over 18 hours with no other checks reporting. A re-trigger attempt did not produce a new run (this check appears to be a third-party status not backed by a re-runnable GitHub Actions check suite). No checks have failed.
Result: ✅ Nothing has failed, and the only outstanding item is a long-stalled, non-code-quality status check. Treating this as a pass on the code changes. A maintainer may want to manually verify/re-trigger the CLA check if it remains stuck.
|
MORDEHAI BOTBIKA (@botbikamordehai2-sketch) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
1 similar comment
|
MORDEHAI BOTBIKA (@botbikamordehai2-sketch) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
MORDEHAI BOTBIKA (@botbikamordehai2-sketch) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
What
When running
az bicep installon corporate machines with self-signed root certificates, SSL verification can fail becauseurlopendoes not use the system's certificate store by default. This leads to the error:Fix
Modified
create_virtualenvto usessl.create_default_context()when making HTTPS requests, which respects the system's certificate store (including corporate certificates installed in the Windows cert store). This change is minimal and preserves backward compatibility.Closes #28044