Skip to content

Bump @tootallnate/once and get-uri - #5203

Merged
Mike Harder (mikeharder) merged 5 commits into
mainfrom
copilot/fix-dependabot-alert-tootallnate-once
Aug 6, 2026
Merged

Bump @tootallnate/once and get-uri#5203
Mike Harder (mikeharder) merged 5 commits into
mainfrom
copilot/fix-dependabot-alert-tootallnate-once

Conversation

Copilot AI commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@tootallnate/once@1.1.2 can leave promises permanently pending when an AbortSignal is aborted. This updates the transitive dependency to patched version 2.0.1.

Changes

  • Added pnpm overrides:
    {
      "@tootallnate/once": "2.0.1",
      "get-uri": "4.0.0"
    }
  • Upgraded get-uri to its first release compatible with once@2’s argument-array API.
  • Regenerated the lockfile, removing vulnerable and incompatible versions.

Reachability Assessment

  • Not reachable — high confidence.
  • The package is only transitive through @azure-tools/uri.
  • No direct @tootallnate/once imports or use of its AbortSignal option were found.
  • This update primarily satisfies vulnerability scanners rather than mitigating an actively exposed path.
Original prompt

This section details the Dependabot vulnerability alert you should resolve

<alert_title>@tootallnate/once vulnerable to Incorrect Control Flow Scoping</alert_title>
<alert_description>Versions of the package @tootallnate/once before 3.0.1 are vulnerable to Incorrect Control Flow Scoping in promise resolving when AbortSignal option is used. The Promise remains in a permanently pending state after the signal is aborted, causing any await or .then() usage to hang indefinitely. This can cause a control-flow leak that can lead to stalled requests, blocked workers, or degraded application availability.</alert_description>

low
GHSA-vpq2-c234-7xj6, CVE-2026-3449
@tootallnate/once
npm
<vulnerable_versions>1.1.2</vulnerable_versions>
<patched_version>2.0.1</patched_version>
<manifest_path>pnpm-lock.yaml</manifest_path>

https://nvd.nist.gov/vuln/detail/CVE-2026-3449 https://github.com/TooTallNate/once/issues/8 https://github.com/TooTallNate/once/commit/b9f43cc5259bee2952d91ad3cdbd201a82df448a https://security.snyk.io/vuln/SNYK-JS-TOOTALLNATEONCE-15250612 https://github.com/TooTallNate/once/releases/tag/v2.0.1 https://github.com/advisories/GHSA-vpq2-c234-7xj6

<task_instructions>Resolve this alert by updating the affected package to a non-vulnerable version. Prefer the lowest non-vulnerable version (see the patched_version field above) over the latest to minimize breaking changes. Include a Reachability Assessment section in the PR description. Review the alert_description field to understand which APIs, features, or configurations are affected, then search the codebase for usage of those specific items. If the vulnerable code path is reachable, explain how (which files, APIs, or call sites use the affected functionality) and note that the codebase is actively exposed to this vulnerability. If the vulnerable code path is not reachable, explain why (e.g. the affected API is never called, the vulnerable configuration is not used) and note that the update is primarily to satisfy vulnerability scanners rather than to address an active risk. If the advisory is too vague to determine reachability (e.g. 'improper input validation' with no specific API named), state that reachability could not be determined and explain why. Include a confidence level in the reachability assessment (e.g. high confidence if the advisory names a specific API and you confirmed it is or is not called, low confidence if the usage is indirect and hard to trace). If no patched version is available, check the alert_description field for a Workarounds section — the advisory may describe configuration changes or usage patterns that mitigate the vulnerability without a version update. If a workaround is available, apply it and leave a code comment referencing the advisory identifier explaining it is a temporary mitigation. If neither a patch nor a workaround is available, explain in the PR description why the alert cannot be resolved automatically so a human reviewer can take over. Inspect the repository to determine which package manager is used (e.g. lock files, config files, build scripts) and use that tooling to perform the update — do not edit lock files directly. If the version constraint in the manifest (e.g. package.json, Gemfile, pyproject.toml) caps the version below the fix, update the constraint first. For transitive dependencies, determine whether it is simpler to update the direct dependency that pulls in the vulnerable package or to update the transitive dependency directly, and choose the least disruptive approach. If upgrading to fix the vulnerability forces a major version bump or known breaking changes, review the changelog or release notes, then audit the codebase for usage of affected APIs and fix any breaking changes that are found. If the package manager fails to resolve dependencies (e.g. peer dependency conflicts, incompatible engine constraints), document the error in the PR description rather than attempting increasingly complex workarounds. After updating, check the lock file to confirm the package no longer resolves to a version in the vulnerable range. Keep changes minimal and tightly scoped. Ensure tests, build, type checking, and linting all pass after your changes. If there are any test, lint, or typechecking failures, investigate whether they are caused by the update and fix them if so — do not leave broken tests in the PR. If they were already present before the update, note them in the PR description so a human reviewer can assess whether they are related.</task_instructions>

Copilot AI and others added 2 commits August 5, 2026 23:38
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Dependabot vulnerability for @tootallnate/once Upgrade @tootallnate/once and compatible get-uri consumer Aug 5, 2026
@azure-pipelines

Copy link
Copy Markdown

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2xmk9l3x For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/285hvmf9 For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2xmk9l3x --use:https://tinyurl.com/285hvmf9

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2xmk9l3x"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/285hvmf9"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@mikeharder Mike Harder (mikeharder) changed the title Upgrade @tootallnate/once and compatible get-uri consumer Bump @tootallnate/once and get-uri Aug 6, 2026
@mikeharder

Copy link
Copy Markdown
Member

Copilot: Change overrides to use "^" instead of pinning

Co-authored-by: mikeharder <9459391+mikeharder@users.noreply.github.com>

Copilot AI commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Copilot: Change overrides to use "^" instead of pinning

Updated both overrides to caret ranges in ff433ef.

@azure-pipelines

Copy link
Copy Markdown

You may test this build by running autorest --reset and then either:


Add the following CLI flags
Pacakge Flag Description
@autorest/core --version:https://tinyurl.com/2b47qv7l For changes to autorest core.
@autorest/modelerfour --use:https://tinyurl.com/26wypn4g For changes to modelerfour.

Or with all

autorest --version:https://tinyurl.com/2b47qv7l --use:https://tinyurl.com/26wypn4g

or use the following in your autorest configuration:
# For changes to autorest core
version: "https://tinyurl.com/2b47qv7l"

# For changes to modelerfour
use-extension:
  "@autorest/modelerfour": "https://tinyurl.com/26wypn4g"

If this build is good for you, give this comment a thumbs up. (👍) And you should run `autorest --reset` again once you're finished testing to remove it.

@mikeharder
Mike Harder (mikeharder) merged commit a3a2971 into main Aug 6, 2026
11 checks passed
@mikeharder
Mike Harder (mikeharder) deleted the copilot/fix-dependabot-alert-tootallnate-once branch August 6, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants