Remove tshy and add warp config generation for HLC (autorest.typescript)#3827
Merged
Remove tshy and add warp config generation for HLC (autorest.typescript)#3827
Conversation
….typescript - Replace tshy config with warp-style exports for Azure monorepo packages - Remove tshy from devDependencies when azureSdkForJs is true - Add generateWarpConfig function to generate warp.config.yml - Export resolveWarpExports from rlc-common index - Regenerate all affected test fixtures Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove tshy and add function to build warp config for hlc
Remove tshy and add warp config generation for HLC (autorest.typescript)
Mar 9, 2026
kazrael2119
reviewed
Mar 9, 2026
packages/autorest.typescript/src/generators/static/packageFileGenerator.ts
Outdated
Show resolved
Hide resolved
Remove the resolveWarpExports import from @azure-tools/rlc-common and inline the exports object directly in packageFileGenerator.ts. Also revert the unnecessary packageCommon.js re-export from rlc-common index. Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
kazrael2119
reviewed
Mar 9, 2026
packages/autorest.typescript/src/generators/static/packageFileGenerator.ts
Outdated
Show resolved
Hide resolved
kazrael2119
requested review from
JialinHuang803,
MaryGao,
joheredi and
qiaozha
as code owners
Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Member
|
@copilot revert commit "815d444bb041830f4d8e6cb5c91db0fc7cd195d1" |
…nfig output) Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Contributor
Author
MaryGao
reviewed
Mar 9, 2026
| return; | ||
| } | ||
|
|
||
| const lines: string[] = []; |
Member
There was a problem hiding this comment.
why line by line? could we share the one in modular to share most common parts?
Member
There was a problem hiding this comment.
this is because in deya's pr, we uses this style
https://github.com/Azure/autorest.typescript/pull/3802/changes#diff-bc88e823f3789bd4f77a10780bde589f8c1f0e103567fab9ef44d09957228cbcR34-R59
…ithub.com/Azure/autorest.typescript into copilot/remove-tshy-add-build-warp-config
MaryGao
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
packageFileGenerator.ts:tshyfrom devDependencies whenazureSdkForJsis truetshyconfig with warp-styleexportswhenazureSdkForJsis true (inlined, no import needed)tshyconfig and devDependency for non-Azure packagesgenerateWarpConfigfunction to createwarp.config.yml(with comment header)typescriptGenerator.tsto callgenerateWarpConfigwhenazureSdkForJsis truepackageCommon.jsre-export fromrlc-commonindexgenerateWarpConfigand generatedwarp.config.ymlfiles)Original prompt
tshyand add a function to build warp config for hlc #3826🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.