feat: skip clone when component repo already exists (#428)#429
Open
sihbher wants to merge 2 commits intoAzure:developfrom
Open
feat: skip clone when component repo already exists (#428)#429sihbher wants to merge 2 commits intoAzure:developfrom
sihbher wants to merge 2 commits intoAzure:developfrom
Conversation
The cleanup block at the end of postProvision.sh fails under set -euo pipefail when rm -rf cannot remove the Python 3.14 venv directory on macOS (file handles still held by recently completed python -m invocations). - Add trap EXIT handler to ensure cleanup runs even on early script exits - Replace rm -rf with python3 shutil.rmtree (handles locked files gracefully) - Skip deactivate at script end (no shell state to restore) Brings postProvision.sh to parity with the care already applied in postProvision.ps1, which has its cleanup commented out for the same reason. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
preDeploy.ps1 and preDeploy.sh unconditionally delete and re-clone all 4 component repos on every azd deploy, even when they already exist locally. - Check if target directory exists before cloning; skip if present - Keep .azure env copy and child deploy execution unconditional - Print informational message when skipping a clone First-time deployments (no local repos) behave identically to before. To force a fresh clone, delete the specific folder before running azd deploy. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sihbher
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Contributing guidelines
Please see Contributing Guidelines before creating your Pull Request.
Type of change
Related Backlog Item or Issue
If applicable, provide a link to the relevant backlog item or issue.
Is this change disruptive or does it break existing applications?
If deploying this change could impact existing applications, please specify.
Cross-Repository Dependencies
If this change depends on pull requests in other repositories within the solution, provide the links below.
Does this require changes to project documentation?
If the changes add new functionality, update the documentation accordingly.
Documentation Link
If this change adds a new functionality, provide a link to its documentation.
Code quality checklist