[SHIR] Install Microsoft JDK and then delete msi to decrease image size

[missingcharacter]

Included changes:

• [SHIR] Install Microsoft JDK and then delete msi to decrease image size
• [SHIR] Remove SHIR msi to decrease image size

[missingcharacter]

@microsoft-github-policy-service agree

[missingcharacter]

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

[jikuja]

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

Which container orchestration did you use?

[jikuja]

Nice additions and JRE/JDK installation was something to add before running this in any production workload.

---

Related ticket: https://github.com/MicrosoftDocs/azure-docs/issues/113486

I did not add any comments for https://github.com/Azure/Azure-Data-Factory-Integration-Runtime-in-Windows-Container/pull/17/files#diff-38ab18146fe7ed8ca5f34789d90179e6212e48f778045320c3a129d18a456849R57-R59

Documentation is really bad but from SO questions, some parts of the documentation and error messages we can see that SHIR tries first to use registry keys and than JAVA_HOME to locate java.dll. Nothing suggests that PATH changes are needed for SHIR. If usage of $JavaHome can be removed from build.ps1 it will significantly simplify required logic for build-time java installer selection.

[missingcharacter]

Which container orchestration did you use?

@jikuja , I tested on Azure App Service on a Service Plan ith Hyper-V: true

[byran77]

Hi @missingcharacter,
nice points to improve. It would be better to separate the changes into different PRs.

[jikuja]

I have been re-iterating this idea on my head...

Would it be possible to do following:

• create SHIR/scripts/.placeholder
• move code that installs JVM into contrib/01-install-jvm.ps1
• modify build.ps1 to execute .ps1 files SHIR/scripts
• document this

This would make easier to extend capabilities by adding files just before build process.

[byran77]

I have been re-iterating this idea on my head...

Would it be possible to do following:

• create SHIR/scripts/.placeholder
• move code that installs JVM into contrib/01-install-jvm.ps1
• modify build.ps1 to execute .ps1 files SHIR/scripts
• document this

This would make easier to extend capabilities by adding files just before build process.

lgtm
It is reasonable to keep only the basic building logic in build.ps1 for better maintainability.

[missingcharacter]

@byran77 I moved GitHub Action to its own PR #19

[missingcharacter]

@byran77 I've updated this PR too

[byran77]

thanks @missingcharacter, it looks good.
One more thing is to add some documents on the building argument INSTALL_JDK

[missingcharacter]

@byran77 I added docs