chore: add validator to ensure unused cached kube binaries are cleaned up#8538
Open
lilypan26 wants to merge 1 commit into
Open
chore: add validator to ensure unused cached kube binaries are cleaned up#8538lilypan26 wants to merge 1 commit into
lilypan26 wants to merge 1 commit into
Conversation
lilypan26
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an E2E validator to ensure versioned (cached) Kubernetes binaries in /opt/bin are cleaned up after installing the correct versions, and wires it into the common Linux validation flow.
Changes:
- Introduce
ValidateStaleCachedKubeBinariesRemovedto detect leftoverkubelet-*/kubectl-*files in/opt/bin. - Run the new validator as part of
ValidateCommonLinux.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| e2e/validators.go | Adds a new validator that scans /opt/bin for leftover versioned kube binaries and fails if any remain. |
| e2e/validation.go | Hooks the new validator into the shared Linux validation path so it runs in all Linux E2Es. |
Comment on lines
+2584
to
+2585
| // List any remaining versioned kubelet/kubectl binaries in /opt/bin/ | ||
| cmd := `find /opt/bin -maxdepth 1 \( -name "kubelet-*" -o -name "kubectl-*" \) -type f 2>/dev/null` |
Comment on lines
+2584
to
+2585
| // List any remaining versioned kubelet/kubectl binaries in /opt/bin/ | ||
| cmd := `find /opt/bin -maxdepth 1 \( -name "kubelet-*" -o -name "kubectl-*" \) -type f 2>/dev/null` |
Comment on lines
+2584
to
+2585
| // List any remaining versioned kubelet/kubectl binaries in /opt/bin/ | ||
| cmd := `find /opt/bin -maxdepth 1 \( -name "kubelet-*" -o -name "kubectl-*" \) -type f 2>/dev/null` |
Devinwong
reviewed
May 20, 2026
Devinwong
approved these changes
May 20, 2026
awesomenix
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #