feat: windows-exporter into windows vhd build by chmill-zz · Pull Request #8516 · Azure/AgentBaker

chmill-zz · 2026-05-13T21:13:11Z

What this PR does / why we need it:

this is adding node-exporter into the vhdbuild by default for windows. At boot CSE will register the service in nssm

Which issue(s) this PR fixes:

Fixes #

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds windows-exporter to the Windows VHD build so nodes can start the aks-windows-exporter service during CSE using VHD-baked assets (with a sentinel to keep aks-vm-extension in no-op mode for these VHDs).

Changes:

Bake windows-exporter binaries/config/health script into the Windows VHD and create a sentinel file.
Register/start aks-windows-exporter at CSE time via new windowsexporterfunc.ps1, with unit tests and VHD content tests.
Add e2e validation ensuring the service is running and serving metrics when the sentinel is present.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vhdbuilder/packer/windows/windows-vhd-builder-sig.json	Stages windows-exporter config + health script into `c:\k\` during image build.
vhdbuilder/packer/windows/configure-windows-vhd.ps1	Extracts/stages windows-exporter into `C:\k\windows-exporter` and creates sentinel.
vhdbuilder/packer/test/windows-vhd-content-test.ps1	Validates windows-exporter assets + sentinel exist on the built VHD.
staging/cse/windows/windowsexporterfunc.ps1	New CSE-time installer to register/start `aks-windows-exporter` via NSSM and health-check it.
staging/cse/windows/windowsexporterfunc.tests.ps1	Adds Pester tests for sentinel/no-op behavior and error code on missing NSSM.
parts/windows/kuberneteswindowssetup.ps1	Dot-sources exporter functions and invokes `Install-WindowsExporter` during BasePrep.
parts/windows/windowscsehelper.ps1	Adds a new Windows CSE error code for windows-exporter start failure.
staging/cse/windows/kubernetesfunc.ps1	Adds Defender exclusions for windows-exporter log file paths.
parts/windows/windowsexporter/windows-exporter-config.yml	New baked config (port 19182, enabled collectors, service include filter, debug logging).
parts/windows/windowsexporter/windows-exporter-health.ps1	New baked health/version helper used by CSE health validation.
parts/common/components.json	Adds windows-exporter component download metadata for VHD caching.
e2e/validators.go	Adds Windows exporter validator (service + metrics) gated by sentinel presence.
e2e/scenario_win_test.go	Runs the new validator across Windows e2e scenarios.
e2e/config/config.go	Fixes a formatting issue in panic error rendering (`%w` -> `%v`).
staging/cse/windows/README	Updates the list of scripts to download, including `windowsexporterfunc.ps1`.

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

github-actions · 2026-05-19T21:51:21Z

Changes cached containers or packages on windows VHDs

Please get a Windows SIG member to approve.

The following dif file shows any additions or deletions from what will be cached on windows VHDs organised by VHD type.

Additions are new things cached.
Deletions are things no longer cached.

diff --git a/vhd_files/2022-containerd-gen2.txt b/vhd_files/2022-containerd-gen2.txt
index ce25fa5..83b378c 100644
--- a/vhd_files/2022-containerd-gen2.txt
+++ b/vhd_files/2022-containerd-gen2.txt
@@ -33,0 +34 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip
diff --git a/vhd_files/2022-containerd.txt b/vhd_files/2022-containerd.txt
index 620eb5a..0110021 100644
--- a/vhd_files/2022-containerd.txt
+++ b/vhd_files/2022-containerd.txt
@@ -33,0 +34 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip
diff --git a/vhd_files/2025-gen2.txt b/vhd_files/2025-gen2.txt
index d5aea5a..d9c995c 100644
--- a/vhd_files/2025-gen2.txt
+++ b/vhd_files/2025-gen2.txt
@@ -31,0 +32 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip
diff --git a/vhd_files/2025.txt b/vhd_files/2025.txt
index 7012908..395b4e0 100644
--- a/vhd_files/2025.txt
+++ b/vhd_files/2025.txt
@@ -31,0 +32 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip
diff --git a/vhd_files/23H2-gen2.txt b/vhd_files/23H2-gen2.txt
index 41b56d8..2e010f7 100644
--- a/vhd_files/23H2-gen2.txt
+++ b/vhd_files/23H2-gen2.txt
@@ -32,0 +33 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip
diff --git a/vhd_files/23H2.txt b/vhd_files/23H2.txt
index efdd638..f8ae8fa 100644
--- a/vhd_files/23H2.txt
+++ b/vhd_files/23H2.txt
@@ -32,0 +33 @@ c:\akse-cache\win-vnet-cni\: https://packages.aks.azure.com/azure-cni/v1.6.21/bi
+c:\akse-cache\windows-exporter\: https://packages.aks.azure.com/dalec-packages/windows-exporter/0.31.2/windows/amd64/windows-exporter_0.31.2-1_amd64.zip

timmy-wright · 2026-05-20T00:19:27Z

+    # carry windowsexporterfunc.ps1 in the CSE script package.
+    if (Get-Command -Name Install-WindowsExporter -ErrorAction SilentlyContinue) {
+        Logs-To-Event -TaskName "AKS.WindowsCSE.InstallWindowsExporter" -TaskMessage "Install aks-windows-exporter if VHD-baked"
+        Install-WindowsExporter


I'm confused. Are we installing and configuring windows exporter during VHD Bake time or during Node Provisioning time? This PR seems to do both. But it only does the installation during node provisioning time if the script to install windows exporter is on the VHD already - which means it will have been done during VHD bake time.

the func being calling "Install-WindowsExporter" might be a bit strong here. During VHD build we add the binarys and config. Then during CSE we use NSSM to create the aks-windows-exporter service(?) and start it and make sure it's healthy. maybe registering/setup would be better than install here

chmill-zz added 2 commits May 13, 2026 20:40

feat: node-exporter windows

4ad14f0

exporter windows

85a6a6b

Copilot AI review requested due to automatic review settings May 13, 2026 21:13

chmill-zz requested review from AbelHu, Devinwong, SriHarsha001, awesomenix, calvin197, cameronmeissner, djsly, ganeshkumarashok, junjiezhang1997, lilypan26, mxj220, pdamianov-dev, phealy, r2k1, sulixu, surajssd, timmy-wright and zachary-bailey as code owners May 13, 2026 21:13

chmill-zz temporarily deployed to test May 13, 2026 21:13 — with GitHub Actions Inactive

Copilot AI reviewed May 13, 2026

View reviewed changes

Comment thread e2e/validators.go Outdated

Comment thread parts/windows/windowsexporter/windows-exporter-config.yml

Comment thread staging/cse/windows/windowsexporterfunc.ps1

Comment thread parts/common/components.json

github-actions Bot added the components This pull request updates cached components on Linux or Windows VHDs label May 13, 2026

Copilot started reviewing on behalf of chmill-zz May 13, 2026 21:41 View session

chmill-zz changed the title ~~feat: node-exporter into windows vhd build~~ feat: windows-exporter into windows vhd build May 14, 2026

fix: address windows exporter review feedback

1d1f938

chmill-zz temporarily deployed to test May 14, 2026 01:38 — with GitHub Actions Inactive

more verbose validation

94a6d6a

Copilot AI review requested due to automatic review settings May 14, 2026 19:01

chmill-zz temporarily deployed to test May 14, 2026 19:01 — with GitHub Actions Inactive

Copilot AI reviewed May 14, 2026

View reviewed changes

Copilot started reviewing on behalf of chmill-zz May 14, 2026 19:22 View session

chmill-zz added 2 commits May 19, 2026 00:16

comments

33a62df

out of scope

b533a02

chmill-zz temporarily deployed to test May 19, 2026 21:40 — with GitHub Actions Inactive

timmy-wright reviewed May 20, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: windows-exporter into windows vhd build#8516

feat: windows-exporter into windows vhd build#8516
chmill-zz wants to merge 6 commits into
mainfrom
exporterWindows

chmill-zz commented May 13, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Uh oh!

timmy-wright May 20, 2026

Uh oh!

chmill-zz May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

chmill-zz commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026

Changes cached containers or packages on windows VHDs

Uh oh!

timmy-wright May 20, 2026

Choose a reason for hiding this comment

Uh oh!

chmill-zz May 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants