test: improve test logging #7841
Merged
+178
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2k1
requested review from
AbelHu,
Devinwong,
YaoC,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
timmy-wright,
yagmurbaydogan,
yewmsft and
zachary-bailey
as code owners
r2k1
force-pushed
the
r2k1/e2e-log-steps
branch
from
516defd to
9cbd299
Compare
r2k1
force-pushed
the
r2k1/e2e-log-steps
branch
from
9cbd299 to
9b3fb2c
Compare
r2k1
force-pushed
the
r2k1/e2e-log-steps
branch
from
9b3fb2c to
ce08c4c
Compare
- Add elapsed timestamps to test log output via testLogger wrapper - Add LogStep helpers that log → start / ✓ done / ✗ failed with timing - Add LogStep to major operations: cluster, VMSS, node/pod wait, ACR, etc. - Remove redundant log lines while keeping skip-reason messages - Fix ##vso wrappers: split into readable + ADO command - Fix LogDuration to always log, emit ##vso only when over threshold - Fix typo isAnonyomusPull → isNonAnonymousPull - Replace logf/log aliases with direct toolkit.Logf/Log calls
r2k1
force-pushed
the
r2k1/e2e-log-steps
branch
from
ce08c4c to
2692766
Compare
r2k1
force-pushed
the
r2k1/e2e-log-steps
branch
from
954be71 to
17d4b6d
Compare
e2e/test_helpers.go
Outdated
Comment on lines
30
to
32
| var ( | ||
| logf = toolkit.Logf | ||
| log = toolkit.Log | ||
| // removed logf and log aliases - use toolkit.Logf and toolkit.Log directly | ||
| ) |
There was a problem hiding this comment.
This var block is now empty, which is invalid Go syntax and will fail compilation. Remove the block entirely (or replace it with a regular comment outside of a var block).
e2e/kube.go
Outdated
|
|
||
| func (k *Kubeclient) createKubernetesSecret(ctx context.Context, namespace, secretName, registryName, username, password string) error { | ||
| logf(ctx, "Creating Kubernetes secret %s in namespace %s", secretName, namespace) | ||
| toolkit.LogStepCtxf(ctx, "creating kubernetes secret %s in namespace %s for registry %s", secretName, namespace, registryName)() |
There was a problem hiding this comment.
LogStepCtxf(... )() is invoked immediately here rather than being deferred, so it will log "done" before the secret creation has actually completed (and it won’t reflect failures). Use defer with the returned function so the end status/timing reflects the whole operation.
Suggested change
| toolkit.LogStepCtxf(ctx, "creating kubernetes secret %s in namespace %s for registry %s", secretName, namespace, registryName)() | |
| done := toolkit.LogStepCtxf(ctx, "creating kubernetes secret %s in namespace %s for registry %s", secretName, namespace, registryName) | |
| defer done() |
Comment on lines
17
to
21
| func LogDuration(ctx context.Context, duration time.Duration, warningDuration time.Duration, message string) { | ||
| Log(ctx, message) | ||
| if duration > warningDuration { | ||
| Logf(ctx, "⚠️ ##vso[task.logissue type=warning;] %s", message) | ||
| } else { | ||
| Log(ctx, message) | ||
| Logf(ctx, "##vso[task.logissue type=warning;]%s", message) | ||
| } |
There was a problem hiding this comment.
LogDuration now always logs message and then logs the same message again as an Azure DevOps warning when the threshold is exceeded, which can create duplicate lines in test output. Consider logging only once in the warning case (either emit only the ##vso[...] line, or keep the normal log and use a shorter warning message).
awesomenix
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testLoggerwrapperLogStephelpers that log→ msg...at start and✓ done (Xs)or✗ failed (Xs)on completion via deferlogf/logpackage-level aliases with directtoolkit.Logf/toolkit.Logcalls to remove it from log stacktrace