feat: track waagent in components.json, install in pre-install-dependencies.sh #7795

mxj220 · 2026-02-05T21:42:04Z

What this PR does / why we need it:
Tracks waagent latest version in components.json via renovate and installs it in pre-install-dependencies.sh.
Which issue(s) this PR fixes:

Fixes #

Copilot

Pull request overview

This PR adds automatic tracking and installation of WALinuxAgent (waagent) from GitHub during cluster provisioning. The implementation allows AKS to use specific waagent versions independent of OS package repository versions.

Changes:

Added walinuxagent package definition to components.json with version 2.15.0.1
Configured Renovate to automatically update walinuxagent from GitHub releases
Implemented installation script that downloads, extracts, and installs waagent from GitHub source
Integrated waagent installation early in CSE basePrep phase (skipped on FLATCAR)
Added waagent.log collection in e2e tests
Updated test data (binary blobs) to reflect new CSE behavior

Reviewed changes

Copilot reviewed 36 out of 70 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
parts/common/components.json	Added walinuxagent package definition with GitHub source and version tracking
.github/renovate.json	Added custom manager for auto-updating walinuxagent from GitHub releases
parts/linux/cloud-init/artifacts/cse_install.sh	Implemented installWALinuxAgent function with download, installation, and service restart logic
parts/linux/cloud-init/artifacts/cse_main.sh	Integrated waagent installation in basePrep phase with FLATCAR exclusion
e2e/vmss.go	Added waagent.log extraction for e2e debugging
pkg/agent/testdata/*	Updated binary test data files (cannot review content)

parts/linux/cloud-init/artifacts/cse_install.sh

parts/linux/cloud-init/artifacts/cse_main.sh

parts/linux/cloud-init/artifacts/cse_install.sh

mxj220 · 2026-02-09T18:44:37Z

Just for my understanding, the here plan is to download and update WaLinuxAgent during VHD build, however during nodePrep, if there is a new WaLinuxAgent available and if some code path does apt upgrade, there is a chance of it getting upgraded ?

@SriHarsha001 Yeah, we want the VHD to start with the latest version at the time of release, and if a newer version is published later on, it can still be pulled via waagent's built-in ability to auto-upgrade when it starts up on the VM.

Devinwong · 2026-02-09T20:31:07Z

parts/common/components.json

+          "current": {
+            "versionsV2": [
+              {
+                "renovateTag": "github=Azure/WALinuxAgent",


Is Renovate really able to detect and automatically pick up new updates for walinuxagent?
It's also fine if you want to test it after merging this PR.

It should be able to. I am not an expert on it, though. The immediately important task is installing a modern version that supports FIPS 140-3 out of the box (2.15.0.1). But the renovate functionality will be tested once another version is released.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

vhdbuilder/packer/pre-install-dependencies.sh

vhdbuilder/packer/install-dependencies.sh

djsly · 2026-02-10T01:46:02Z

vhdbuilder/packer/install-dependencies.sh

+    "walinuxagent")
+      if isFlatcar "$OS"; then
+        echo "  - walinuxagent installation skipped on Flatcar; using image-provided version" >> ${VHD_LOGS_FILEPATH}
+      else


Do we need the if else ? If in the end we simply print a message ? In both cases

It's not required for any reason other than clarity

djsly · 2026-02-10T01:48:13Z

vhdbuilder/packer/pre-install-dependencies.sh

+      if isMarinerOrAzureLinux "$OS"; then
+        echo "Removing OS-packaged WALinuxAgent RPM before source install..."
+        dnf remove -y WALinuxAgent --noautoremove || true
+      fi


We don’t uninstall on Linux ?

I was misled by trying to debug an osguard issue. dnf/apt remove should not be necessary

vhdbuilder/packer/pre-install-dependencies.sh

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Copilot · 2026-02-10T18:57:55Z

vhdbuilder/packer/pre-install-dependencies.sh

+      elif systemctl list-unit-files waagent.service | grep -q waagent; then
+        if ! systemctl restart waagent.service; then
+          exit 1
+        fi


The service restart logic has a potential issue: if neither walinuxagent.service nor waagent.service is found, the script continues silently without restarting the service. This could leave waagent running with the old version or not running at all. Consider adding an else branch to fail with a clear error message if no recognized service file is found after installation.

Suggested change

fi

fi

else

echo "Error: No recognized WALinuxAgent/waagent systemd service unit found after installation; unable to restart agent." >&2

exit 1

Copilot · 2026-02-10T18:57:55Z

vhdbuilder/packer/pre-install-dependencies.sh

+      if ! python3 setup.py install --register-service; then
+        popd > /dev/null || exit 1
+        exit 1
+      fi


The waagent installation uses python3 setup.py install --register-service, which depends on python3 being available and the setup.py script working correctly across different OS distributions. While Ubuntu and Azure Linux both have python3, there could be subtle differences in Python package installation behavior between distributions.

Additionally, the --register-service flag is WALinuxAgent-specific and registers systemd service files. Verify that this works correctly on both Ubuntu and Azure Linux distributions. If either OS uses a different init system or has different systemd configuration, this could fail silently.

Consider adding explicit checks for:

Python3 availability

Setup.py execution success

Service file creation success before attempting restart

e2e/vmss.go

vhdbuilder/packer/pre-install-dependencies.sh

.github/renovate.json

Copilot · 2026-02-10T18:57:56Z

vhdbuilder/packer/test/linux-vhd-content-test.sh

+testWaagentInstalled() {
+  local test="testWaagentInstalled"
+  echo "$test:Start"
+  # walinuxagent is not installed from source on Flatcar or OS Guard
+  if [ "$OS_SKU" = "Flatcar" ] || [ "$OS_SKU" = "AzureLinuxOSGuard" ]; then
+    echo "$test: Skipping for ${OS_SKU} as waagent is not installed from source"
+    echo "$test:Finish"
+    return
+  fi
+  local expectedVersion="$1"
+  # walinuxagent is installed from source during VHD build and the download artifacts are cleaned up,
+  # so we verify installation by checking the installed version matches what components.json specifies
+  local installedVersion
+  installedVersion=$(waagent --version 2>/dev/null | head -n1 | sed -n 's/.*WALinuxAgent-\([0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(\.[0-9][0-9]*\)*\).*/\1/p' || true)
+  if [ -z "$installedVersion" ]; then
+    err $test "walinuxagent is not installed or waagent --version failed"
+  elif [ "$installedVersion" != "$expectedVersion" ]; then
+    err $test "walinuxagent version mismatch: installed ${installedVersion}, expected ${expectedVersion}"
+  else
+    echo "$test walinuxagent version ${installedVersion} is installed correctly"
+  fi
+  echo "$test:Finish"
+}


The waagent test only validates that the version matches, but doesn't verify:

That the waagent service is actually running after installation

That waagent.conf contains the expected AKS log collector configuration

That the service restart succeeded during VHD build

Consider enhancing the test to check:

Service status: systemctl is-active walinuxagent.service or systemctl is-active waagent.service

Config file contains expected settings: grep -q "Logs.Collect=n" /etc/waagent.conf

Waagent can communicate with Azure fabric (basic functionality test)

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-10T22:49:17Z

vhdbuilder/packer/test/linux-vhd-content-test.sh

+  # walinuxagent is installed from source during VHD build and the download artifacts are cleaned up,
+  # so we verify installation by checking the installed version matches what components.json specifies
+  local installedVersion
+  installedVersion=$(waagent --version 2>/dev/null | head -n1 | sed -n 's/.*WALinuxAgent-\([0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(\.[0-9][0-9]*\)*\).*/\1/p' || true)


The regex pattern for extracting the WALinuxAgent version from waagent --version output is fragile. The pattern s/.*WALinuxAgent-$[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(\.[0-9][0-9]*$*\).*/\1/p assumes:

The version string always appears after "WALinuxAgent-"

Each version component has at least 2 digits (e.g., "01" instead of "1")

However, actual WALinuxAgent version output may vary:

It might be "WALinuxAgent-2.15.0.1" (works)

It might be "WALinuxAgent-2.15.0.10" (works because * allows 2+ digits)

But pattern won't match if components have only 1 digit like "WALinuxAgent-2.5.0.1"

The pattern should be: s/.*WALinuxAgent-$[0-9]\+\.[0-9]\+\.[0-9]\+\(\.[0-9]\+$*\).*/\1/p to match 1 or more digits per component, not 2+ digits.

Suggested change

installedVersion=$(waagent --version 2>/dev/null | head -n1 | sed -n 's/.*WALinuxAgent-$[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\(\.[0-9][0-9]*$*\).*/\1/p' || true)

installedVersion=$(waagent --version 2>/dev/null | head -n1 | sed -n 's/.*WALinuxAgent-$[0-9]\+\.[0-9]\+\.[0-9]\+\(\.[0-9]\+$*\).*/\1/p' || true)

mxj220 added 2 commits February 5, 2026 21:37

feat: track waagent in components.json, install in cse

240ef49

update customdata

ec03134

mxj220 requested a review from yewmsft as a code owner February 5, 2026 21:42

Copilot AI review requested due to automatic review settings February 5, 2026 21:42

mxj220 requested review from AbelHu, Devinwong, YaoC, awesomenix, cameronmeissner, djsly, ganeshkumarashok, juan-lee, junjiezhang1997, lilypan26, pdamianov-dev, phealy, r2k1, timmy-wright and zachary-bailey as code owners February 5, 2026 21:42

mxj220 temporarily deployed to test February 5, 2026 21:42 — with GitHub Actions Inactive

github-actions bot added the components This pull request updates cached components on Linux or Windows VHDs label Feb 5, 2026

Copilot started reviewing on behalf of mxj220 February 5, 2026 21:42 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

download in install-deps

75f406f

mxj220 temporarily deployed to test February 5, 2026 22:48 — with GitHub Actions Inactive

awesomenix reviewed Feb 5, 2026

View reviewed changes

parts/linux/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

cameronmeissner reviewed Feb 6, 2026

View reviewed changes

parts/linux/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

cameronmeissner reviewed Feb 6, 2026

View reviewed changes

parts/linux/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

cameronmeissner reviewed Feb 6, 2026

View reviewed changes

parts/linux/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

cameronmeissner reviewed Feb 6, 2026

View reviewed changes

parts/linux/cloud-init/artifacts/cse_install.sh Outdated Show resolved Hide resolved

mxj220 temporarily deployed to test February 9, 2026 18:40 — with GitHub Actions Inactive

SriHarsha001 mentioned this pull request Feb 9, 2026

fix: run aptmarkwalinuxagent hold operation on foreground #7797

Merged

Devinwong reviewed Feb 9, 2026

View reviewed changes

bug fixes

98d2a6d

Copilot AI review requested due to automatic review settings February 9, 2026 23:18

mxj220 temporarily deployed to test February 9, 2026 23:18 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mxj220 February 9, 2026 23:19 View session

Copilot AI reviewed Feb 9, 2026

View reviewed changes

vhdbuilder/packer/pre-install-dependencies.sh Show resolved Hide resolved

vhdbuilder/packer/pre-install-dependencies.sh Show resolved Hide resolved

vhdbuilder/packer/pre-install-dependencies.sh Show resolved Hide resolved

djsly reviewed Feb 10, 2026

View reviewed changes

vhdbuilder/packer/install-dependencies.sh Outdated Show resolved Hide resolved

djsly reviewed Feb 10, 2026

View reviewed changes

vhdbuilder/packer/pre-install-dependencies.sh Show resolved Hide resolved

djsly reviewed Feb 10, 2026

View reviewed changes

vhdbuilder/packer/pre-install-dependencies.sh Outdated Show resolved Hide resolved

Skip osguard, don't remove from dnf, backup waagent.conf

8aeb668

mxj220 temporarily deployed to test February 10, 2026 17:44 — with GitHub Actions Inactive

fix path

32191c5

Copilot AI review requested due to automatic review settings February 10, 2026 18:47

mxj220 temporarily deployed to test February 10, 2026 18:47 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mxj220 February 10, 2026 18:48 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

installation changes

40a9d29

mxj220 temporarily deployed to test February 10, 2026 19:23 — with GitHub Actions Inactive

python3 only

87f3da9

Copilot AI review requested due to automatic review settings February 10, 2026 22:41

mxj220 temporarily deployed to test February 10, 2026 22:41 — with GitHub Actions Inactive

Copilot started reviewing on behalf of mxj220 February 10, 2026 22:42 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

python3 patch

ab1e7de

mxj220 temporarily deployed to test February 10, 2026 23:09 — with GitHub Actions Inactive

-        fi
+        fi
+      else
+        echo "Error: No recognized WALinuxAgent/waagent systemd service unit found after installation; unable to restart agent." >&2
+        exit 1

	installedVersion=$(waagent --version 2>/dev/null \| head -n1 \| sed -n 's/.WALinuxAgent-\([0-9][0-9]\.[0-9][0-9]\.[0-9][0-9]\(\.[0-9][0-9]\)\).*/\1/p' \|\| true)
	installedVersion=$(waagent --version 2>/dev/null \| head -n1 \| sed -n 's/.WALinuxAgent-\([0-9]\+\.[0-9]\+\.[0-9]\+\(\.[0-9]\+\)\).*/\1/p' \|\| true)

feat: track waagent in components.json, install in pre-install-dependencies.sh #7795

Are you sure you want to change the base?

feat: track waagent in components.json, install in pre-install-dependencies.sh #7795

Conversation

mxj220 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mxj220 commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Devinwong Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

mxj220 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

djsly Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mxj220 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

djsly Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

mxj220 Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

mxj220 commented Feb 5, 2026 •

edited

Loading

mxj220 commented Feb 9, 2026 •

edited

Loading