Adding dynamic allowed value creation, hiding allowed values and filtering invalid dynamically created allowed values.#8
Merged
lovelysandwich merged 4 commits intomainfrom Mar 21, 2023
Conversation
lovelysandwich
changed the title
lovelysandwich
commented
Mar 21, 2023
| "Display": false, | ||
| "Description": "Getting Azure deployment locations.", | ||
| "Type": "PSScript", | ||
| "Script": "Get-AzLocation | Sort-Object Location | Select-Object -ExpandProperty Location | Where-Object {$_ -notmatch 'asia|(.*)stage$'}", |
Contributor
Author
There was a problem hiding this comment.
Any values I should have removed with this pretty naïve Regex?
lovelysandwich
commented
Mar 21, 2023
| $allowedValues = $configValue.AllowedValues | ||
| $hasAllowedValues = $null -ne $configValue.AllowedValues | ||
| #if the file has a script - execute it: | ||
| if ($null -ne $configValue.AllowedValues -and $configValue.AllowedValues.Type -eq "PSScript") { |
Contributor
Author
There was a problem hiding this comment.
This script execution might be a bit weird... Happy to discuss...
Nepomuceno
approved these changes
Mar 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
An mechanism which allows for dynamically calculated AllowedValues to be specified. Also configurable whether the allowed values are displayed or not.
Note. This might be entirely too configurable - what do you think about this approach...(?)
Issue
Azure/Azure-Landing-Zones#2567
Description
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.