Fixing bugs with complex value replacement needed.#26
Merged
lovelysandwich merged 1 commit intomainfrom Mar 30, 2023
Merged
Conversation
…ple powershell expressions...
lovelysandwich
commented
Mar 29, 2023
| }, | ||
| "AllSubscriptionIds": { | ||
| "Type": "Computed", | ||
| "Process": "@($args | Select-Object -Unique)", |
Contributor
Author
There was a problem hiding this comment.
Might want to consider casing here... Perhaps tolower on the inputs before we test for uniqueness...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Azure/Azure-Landing-Zones#2568
Azure/Azure-Landing-Zones#2557
Description
Adding functionality to modify values before they're set based on simple PowerShell expressions...
This might be questionable - but I couldn't think of another way to easily deal with lots of situations where logic would need to be executed in response to user input.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.