Fix: add build script to postinstall script#121
Open
yulei-chen wants to merge 1 commit intoAzure-Samples:mainfrom
Open
Fix: add build script to postinstall script#121yulei-chen wants to merge 1 commit intoAzure-Samples:mainfrom
build script to postinstall script#121yulei-chen wants to merge 1 commit intoAzure-Samples:mainfrom
Conversation
|
This solved the problem for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Purpose
This PR adds a
npm run buildscript topostinstallscript in/1-Authentication/1-Sign-in/App/package.json, to solve the following problem when runningnpm startThis bug is because it's the first time I run
npm startin any chapter, the helper inside/Commonhasn't been built before.Actually, we need to add
npm run buildto everypostinstallin case of the above bug, but this PR just adds for/1-Authentication/1-sign-in/.Does this introduce a breaking change
Pull request type
What kind of change does this Pull Request introduce?
How to test
What to check
ex: verify that the following are valid:
npm startOther Information
Related issue: Please Fix the following issue I was having when running npm start in sample \4-AccessControl\2-security-groups · Issue #100 · Azure-Samples/ms-identity-javascript-nodejs-tutorial