Split insertion and extraction value tracking in pipe stats#1247
Merged
Technici4n merged 1 commit intoAztechMC:1.21.xfrom Mar 4, 2026
Merged
Split insertion and extraction value tracking in pipe stats#1247Technici4n merged 1 commit intoAztechMC:1.21.xfrom
Technici4n merged 1 commit intoAztechMC:1.21.xfrom
Conversation
Technici4n
reviewed
Mar 3, 2026
src/main/java/aztech/modern_industrialization/pipes/PipeStatsCollector.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a niche bug in how the pipe statistics tracking works.
If an extraction and an insertion don't happen in the same tick, the effective flow rate is doubled because both operations are tracked as individual steps. My fix separates the tracking of the extraction and the insertion, and takes the higher value for the statistics value.
The bug can be reproduced by a machine that only uses energy every 2 ticks.
A more in-depth discussion about this issue can be found on the Discord.