fix(batch): emit void for registerContract results over the wire - #60
Merged
Conversation
The v5 Wallet interface makes registerContract return void, and the SDK's batch output schema validates each registerContract result as z.void().optional(). The batch handler was forwarding the operation's internal return value — the contract instance, which we keep as the "already registered" early-return sentinel — as the wire result, so an app batching registerContract calls rejected the response with "expected void" (invalid_type) zod errors, one per batched item. Emit undefined as the batch wire result for registerContract. The standalone registerContract path already returns void, and registerContract is the only batchable method whose wallet-interface return type is void. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🚀 Web wallet deployed! Preview URL: https://demo-wallet-qoipncu0e-thunkars-projects.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v5 Wallet interface makes registerContract return void, and the SDK's batch output schema validates each registerContract result as z.void().optional(). The batch handler was forwarding the operation's internal return value — the contract instance, which we keep as the "already registered" early-return sentinel — as the wire result, so an app batching registerContract calls rejected the response with "expected void" (invalid_type) zod errors, one per batched item.
Emit undefined as the batch wire result for registerContract. The standalone registerContract path already returns void, and registerContract is the only batchable method whose wallet-interface return type is void.