fix(toolbar): remove search-switch divider before rightSlot - #20
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates the Toolbar so that the vertical divider before the rightSlot is suppressed in the search-switch variant, while preserving the divider in other toolbar variants such as anonimizador and set-de-datos. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new inline comment is quite detailed and design-specific; consider trimming it to a brief rationale and move Figma node references to a design doc or commit message to keep the component code focused.
- Since
isSearchSwitchnow controls both search width and divider visibility, it might be worth extracting a small helper or clarifying naming to make its role as the "search-with-switch" mode more explicit for future maintainers.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new inline comment is quite detailed and design-specific; consider trimming it to a brief rationale and move Figma node references to a design doc or commit message to keep the component code focused.
- Since `isSearchSwitch` now controls both search width and divider visibility, it might be worth extracting a small helper or clarifying naming to make its role as the "search-with-switch" mode more explicit for future maintainers.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the vertical divider
Toolbarwas rendering between the search box andrightSlotin thesearch-switchcontext — found while integrating v0.4.2 intodesktop-app's Voz a Texto edit screen.Figma node
40002322-57362(basesearch-switchtoolbar) shows the search box and "Modo Edición" switch with plain empty space between them, no divider line. The component's own doc comment already only describes a divider foranonimizador/set-de-datos("Search (wide) + vertical divider + ...", "Search + vertical divider + ..."); thesearch-switchline never mentioned one ("Search (wide) + Switch+label"), confirming it was never intended there.One-line conditional gate (
{!isSearchSwitch && <ToolbarDivider />}), following the exact sameisSearchSwitchpattern already used in this file for the search-width fix (PR #19). No new component, no API change.Compatibility
ToolbarProps.anonimizador/set-de-datosuntouched — both still render their divider.Player's unrelatedrightSlotprop (different component) is unaffected.Verification
pnpm typecheck/pnpm biome check— pass.SearchSwitchandSearchSwitchWithResultsno longer show the divider before "Modo Edición";Anonimizadorstill shows its divider before the tool buttons, confirming no regression.Summary by Sourcery
Bug Fixes: