Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 28 additions & 2 deletions listener/listener.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ package listener

import (
"context"
"crypto/tls"
"errors"
"log"
"net"
Expand All @@ -19,6 +20,7 @@ type Listener struct {
activeConns map[net.Conn]struct{}
mu sync.Mutex
wg sync.WaitGroup
tlsConfig *tls.Config
}

func NewListener(px ProxyIO) *Listener {
Expand All @@ -31,6 +33,20 @@ func NewListener(px ProxyIO) *Listener {
}
}

func NewTLSListener(px ProxyIO, cfg *tls.Config) *Listener {
if px == nil {
panic("proxy cannot be nil")
}
if cfg == nil {
panic("tls config cannot be nil")
}
return &Listener{
proxy: px,
activeConns: make(map[net.Conn]struct{}),
tlsConfig: cfg,
}
}

func (l *Listener) Listen(ln net.Listener) {
l.ln = ln
defer ln.Close()
Expand Down Expand Up @@ -62,14 +78,24 @@ func (l *Listener) Listen(ln net.Listener) {
delete(l.activeConns, conn)
l.mu.Unlock()
}()
err := l.proxy.Handle(conn)
if err != nil {
if err := l.handleConn(conn); err != nil {
log.Printf("connection %s: %v", conn.RemoteAddr(), err)
}
}()
}
}

func (l *Listener) handleConn(conn net.Conn) error {
if l.tlsConfig != nil {
server := tls.Server(conn, l.tlsConfig)
if err := server.Handshake(); err != nil {
return err
}
conn = server
}
return l.proxy.Handle(conn)
}

func (l *Listener) GracefulShutdown(ctx context.Context) {
l.ln.Close()

Expand Down
68 changes: 68 additions & 0 deletions listener/listener_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ package listener

import (
"context"
"crypto/ecdsa"
"crypto/elliptic"
"crypto/rand"
"crypto/tls"
"crypto/x509"
"math/big"
"net"
"sync"
"testing"
Expand Down Expand Up @@ -125,6 +131,68 @@ func TestGracefulShutdownWaitsForConnections(t *testing.T) {
}
}

func generateTLSConfigs(t *testing.T) (serverCfg *tls.Config, clientCfg *tls.Config) {
t.Helper()
key, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader)
if err != nil {
t.Fatal(err)
}
template := &x509.Certificate{
SerialNumber: big.NewInt(1),
NotBefore: time.Now(),
NotAfter: time.Now().Add(time.Hour),
IPAddresses: []net.IP{net.ParseIP("127.0.0.1")},
}
certDER, err := x509.CreateCertificate(rand.Reader, template, template, &key.PublicKey, key)
if err != nil {
t.Fatal(err)
}
cert := tls.Certificate{Certificate: [][]byte{certDER}, PrivateKey: key}
return &tls.Config{Certificates: []tls.Certificate{cert}},
&tls.Config{InsecureSkipVerify: true}
}

func TestTLSListenerHandshake(t *testing.T) {
serverCfg, clientCfg := generateTLSConfigs(t)
proxy := newStubProxy()
close(proxy.block)
l := NewTLSListener(proxy, serverCfg)
addr := startListener(t, l)
defer l.GracefulShutdown(context.Background())

conn, err := tls.Dial("tcp", addr, clientCfg)
if err != nil {
t.Fatalf("tls dial failed: %v", err)
}
defer conn.Close()

select {
case <-proxy.called:
case <-time.After(time.Second):
t.Error("proxy Handle was not called after TLS handshake")
}
}

func TestTLSListenerRejectsPlainConn(t *testing.T) {
serverCfg, _ := generateTLSConfigs(t)
proxy := newStubProxy()
l := NewTLSListener(proxy, serverCfg)
addr := startListener(t, l)
defer l.GracefulShutdown(context.Background())

conn, err := net.Dial("tcp", addr)
if err != nil {
t.Fatal(err)
}
defer conn.Close()

select {
case <-proxy.called:
t.Error("expected Handle not to be called on failed handshake")
case <-time.After(200 * time.Millisecond):
}
}

func TestGracefulShutdownForcesCloseOnDeadline(t *testing.T) {
proxy := newStubProxy()
l := NewListener(proxy)
Expand Down
Loading