Merged
Conversation
The chat list refreshable modifier only read from the local database, which already reloads automatically via onChange handlers. The offline alert it triggered was misleading since no BLE connection is needed.
Update Package.swift, project.yml, swiftgen.yml, .gitignore, .swiftlint.yml, and Info.plist files with new MC1 names and MeshCore One user-facing strings. Preserved bundle IDs and URL schemes unchanged.
- Add -project MC1.xcodeproj to xcodebuild build commands in test.yml and build-ipa.yml to avoid ambiguity when stale .xcodeproj exists - Add CFBundleDisplayName "MeshCore One" to both Info.plist files so the home screen shows the full name instead of the target name "MC1"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserved identifiers (no change)
These remain unchanged to avoid breaking existing installs:
io.pocketmesh.app,io.pocketmesh.app.debug,io.pocketmesh.app.widgets,io.pocketmesh.app.debug.widgetscom.pocketmesh.lastConnectedDeviceID,com.pocketmesh.lastConnectedDeviceName,com.pocketmesh.lastDisconnectDiagnostic,com.pocketmesh.userExplicitlyDisconnectedcom.pocketmesh.nodepasswordscom.pocketmesh.ble.centralpocketmesh://,pocketmesh-hashtag://Test plan
xcodebuild build— 0 errors, 0 warningsxcodebuild test— 907 tests passed, 0 failuresswift test --package-path MC1Services— 660 tests passed, 0 failuresswiftlint lint— 0 new violations (12 pre-existing)PocketMeshreferences (excluding preserved identifiers)