A field needs not end with a new line#55
Open
kztk-m wants to merge 1 commit intoAvi-D-coder:masterfrom
Open
Conversation
Added a function `skipToNextLineOrEOI` and changed `field` to call the function instead. This function may consume no inputs, and hence `many skipToNextLineOrEOI` can go to infinite loop.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of
fieldso that it can parse a field that does not end with a new line, addressing #54.In the latest version, it seems to me that
fieldis used only inextractPkgs. So, I have only testedextractPkgsin REPL.It works as expected for my example used in #54.
I also confirmed the following behavior is kept unchanged for this commit.
I haven't checked how this change affects 0.1.2.7, which I understand is what is called 0.1.4.0 and uses the
fieldfunction in places other thanextractPkgs.