Conversation
When playing Spider, after there are no more cards in stock, it becomes impossible to move cards into empty slots. This commit fixes the issue by making sure the game logic compares the source and destionation by reference, instead of using the number of cards in source and destination.
Nippius
changed the title
|
It is possible this could be fixed? It makes the Spider card game almost impossible to finish. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When playing Spider, after there are no more cards in the stack, it becomes impossible to move cards into empty slots.
This commit fixes the issue by making sure the game logic compares the source and destination by reference, instead of using the number of cards in source and destination.
It should also fix issue #22