HTTP local server fallback for WebAuthenticationBroker - #73
Merged
Conversation
…rOptions.BrowserOptions
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #26
System OAuth WebAuthenticationBroker implementation is not always available. And NativeWebDialog implementation might not be desirable (as it's not connected with user browser sessions).
In the wild, many apps implement HTTP listener, including our own tooling. This new WebAuthenticationBroker brings the same fallback to this library.
New API:
public record WebAuthenticatorOptions(Uri RequestUri, Uri RedirectUri) { + public WebAuthenticatorMode Mode { get; init; } + [Obsolete("Use Mode = WebAuthenticatorMode.NativeWebDialog instead.")] public bool PreferNativeWebDialog { get; init; } public bool NonPersistent { get; init; } public Func<NativeWebDialog?>? NativeWebDialogFactory { get; init; } + public BrowserOptions? BrowserOptions { get; init; } }