Skip to content

Record the pinned deploy action version in its comment - #160

Merged
GaryJones merged 1 commit into
developfrom
fix/action-version-comment
Jun 17, 2026
Merged

Record the pinned deploy action version in its comment#160
GaryJones merged 1 commit into
developfrom
fix/action-version-comment

Conversation

@GaryJones

Copy link
Copy Markdown
Contributor

Summary

The release workflow pins 10up/action-wordpress-plugin-deploy to a full commit SHA, which is what we want for supply-chain safety. The trailing comment, though, read # stable rather than naming a release, so the pin was not auditable at a glance: a reviewer could not tell which version that SHA represents without resolving it by hand, and "stable" misleadingly implies a moving target when the pin is in fact fixed.

The pinned SHA (54bd289b…) resolves to tag 2.3.0, so the comment now records that. Nothing functional changes: the commit SHA is untouched, so the workflow deploys using exactly the same action version as before, the label just now identifies it.

@GaryJones
GaryJones requested a review from a team as a code owner June 17, 2026 16:09
The version comment beside the SHA-pinned plugin-deploy action read
"stable" rather than naming the release. The pinned SHA resolves to tag
2.3.0, so the comment now records that, making the pin auditable at a
glance. Only the comment changes; the commit SHA is untouched.
@GaryJones
GaryJones force-pushed the fix/action-version-comment branch from d1ee7bd to 6f30c13 Compare June 17, 2026 16:19
@GaryJones
GaryJones changed the base branch from main to develop June 17, 2026 16:20
@GaryJones GaryJones added this to the Next milestone Jun 17, 2026
@GaryJones
GaryJones merged commit 44d688f into develop Jun 17, 2026
4 checks passed
@GaryJones
GaryJones deleted the fix/action-version-comment branch June 17, 2026 16:22
@GaryJones GaryJones self-assigned this Jun 17, 2026
@GaryJones GaryJones added the type: maintenance Routine maintenance and code quality improvements label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: maintenance Routine maintenance and code quality improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant