Skip to content

fix: reinstate left border for quotes#2720

Merged
laurelfulford merged 2 commits into
releasefrom
fix/readd-quote-styles
May 21, 2026
Merged

fix: reinstate left border for quotes#2720
laurelfulford merged 2 commits into
releasefrom
fix/readd-quote-styles

Conversation

@laurelfulford
Copy link
Copy Markdown
Contributor

All Submissions:

Changes proposed in this Pull Request:

As of upgrading to WordPress 7.0, some Newspack sites have lost the left border on the Quote block on the front-end. The border style and width, plus left padding are normally added inline. They still work in the editor.

I can't recreate this locally but can see it on live sites and confirmed the missing styles are contributing.

This PR adds the style (solid) and left padding to the theme directly to avoid issues where this is missing.

How to test the changes in this Pull Request:

I haven't been able to recreate this, but:

  1. Apply the PR and build.
  2. Add two Quote blocks, one with the default style and one with the plain style. Publish.
  3. Confirm the Quote block with the default style has a 2px border on the left in the editor and the front-end, and the one with the plain style does not.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the theme’s front-end Quote block styling to ensure the default Quote variant reliably renders with a left border after WordPress 7.0, even when expected inline styles are missing.

Changes:

  • Adjusts the .wp-block-quote rule for non-large/non-plain quotes to explicitly set a left border.
  • Refines the conditional selector for which quote styles should receive the border.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread newspack-theme/sass/blocks/_blocks.scss Outdated
Comment thread newspack-theme/sass/blocks/_blocks.scss Outdated
@laurelfulford laurelfulford marked this pull request as ready for review May 21, 2026 15:50
@laurelfulford laurelfulford requested a review from a team as a code owner May 21, 2026 15:50
@laurelfulford
Copy link
Copy Markdown
Contributor Author

This is a two-line CSS fix, so merging without review.

@laurelfulford laurelfulford merged commit 357a196 into release May 21, 2026
9 checks passed
@laurelfulford laurelfulford deleted the fix/readd-quote-styles branch May 21, 2026 15:51
@github-actions
Copy link
Copy Markdown

Hey @laurelfulford, good job getting this PR merged! 🎉

Now, the needs-changelog label has been added to it.

Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label.

If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label.

Thank you! ❤️

matticbot pushed a commit that referenced this pull request May 21, 2026
## [2.22.1](v2.22.0...v2.22.1) (2026-05-21)

### Bug Fixes

* reinstate left border for quotes ([#2720](#2720)) ([357a196](357a196))
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions Bot pushed a commit to Automattic/newspack-workspace that referenced this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants