fix(nelson): increase content width to accommodate 728px ads#2716
Open
faisalahammad wants to merge 1 commit into
Open
fix(nelson): increase content width to accommodate 728px ads#2716faisalahammad wants to merge 1 commit into
faisalahammad wants to merge 1 commit into
Conversation
Reduce #primary desktop padding from 3rem to 2rem per side so .main-content reaches >= 728px width for ad placements. Fixes Automattic#1527
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Newspack Nelson's
#primaryhas extra horizontal padding (3rem per side at desktop) that narrows the content area to ~702px, preventing 728px wide ads from fitting. Reducing desktop padding to 2rem per side brings the content width to >= 728px.Fixes #1527
Changes
newspack-nelson/sass/style.scss
Before:
After:
Why: 3rem (48px) padding per side at desktop was Nelson-specific — no other child theme adds padding to
#primary. Reducing to 2rem (32px) matches the tablet breakpoint value and gives.main-contentenough width for 728px ads while keeping the visual difference minimal.Testing
.main-content— computed width should be >= 728pxBuild
newspack-nelson-fix-1527.zip available for manual testing. Install via WP Admin -> Appearance -> Themes -> Upload Theme.