fix: move editor ad block padding to Sass

[faisalahammad]

Summary

The editor ad block had padding: 8px conditionally applied in color-patterns.php only when a custom ad background color was set. This made spacing inconsistent — padding was absent with default colors, present with custom colors. Moved it to style-editor-base.scss so it always applies, matching front-end behavior.

Fixes #1700

Changes

newspack-theme/inc/color-patterns.php

Before:

.wp-block-newspack-ads-blocks-ad-unit > div {
    background-color: ' . esc_attr( get_theme_mod( 'ads_color_hex', '#ffffff' ) ) . ';
    padding: 8px;
}

After:

.wp-block-newspack-ads-blocks-ad-unit > div {
    background-color: ' . esc_attr( get_theme_mod( 'ads_color_hex', '#ffffff' ) ) . ';
}

Why: Padding is a layout concern, not a color concern. Keeping it in the color-conditional block made editor spacing depend on customizer state.

newspack-theme/sass/style-editor-base.scss

Before:

.wp-block-newspack-ads-blocks-ad-unit {
    > div {
        align-items: center;
        display: flex;
        justify-content: center;
    }
}

After:

.wp-block-newspack-ads-blocks-ad-unit {
    > div {
        align-items: center;
        display: flex;
        justify-content: center;
        padding: 8px;
    }
}

Why: Consolidates editor ad block styles in one location. Padding now applies unconditionally, consistent with how the front-end handles ad widget padding in newspack-ads.scss.

Testing

1. Inspect compiled style-editor.css — .wp-block-newspack-ads-blocks-ad-unit > div should contain padding:8px
2. In color-patterns.php, the ad editor block should only output background-color
3. With Newspack Ads plugin: insert ad unit block in editor, verify consistent padding regardless of customizer ad color setting