fix(social-icons): add Google News icon and domain mapping

[faisalahammad]

Summary

Adds a dedicated Google News social icon and domain mapping so news.google.com URLs in the social menu display the correct icon instead of falling back to the generic Google logo or chain-link icon.

Fixes #2213

Changes

newspack-theme/classes/class-newspack-svg-icons.php

Before: No google-news mapping or SVG existed. news.google.com URLs received no match, falling through to the generic link icon.

After: Added google-news entry to both $social_icons_map and $social_icons arrays:

• Domain mapping: news.google.com
• SVG: Newspaper-style icon matching the Google News brand

Why: Follows existing patterns — apple-news is similarly distinct from apple. The Google News icon is visually different from the generic Google "G" logo.

Testing

Test: Google News menu link

1. Open Appearance → Menus → Social Links Menu
2. Add a custom link with URL https://news.google.com/publications/...
3. Save and view frontend
4. Confirm the link shows a newspaper icon, not the Google "G" or chain-link

[laurelfulford]

Thanks for taking a swing at this one, @faisalahammad!

I added a bit of feedback in a code comment.

Also I'm not sure if this is what you intended to load as an icon (on the left):

This is what Google News has for its official icon - it's pretty big and busy compared to the other icons used in the social links menu, so I get why it wasn't the first choice! As a middle ground, what do you think about explicitly assigning the Google icon (the G in the screenshot above) to news.google.com? That way it won't load the link icon, but will be recognizable as Google and still fit in?

[laurelfulford]

Given how the SVGs are read, the icon for Google is getting picked up first for Google News. The quickest way to fix would be to move the icon here, before 'Google'.

[faisalahammad]

Hi @laurelfulford,

Thanks for the catch! I've updated the PR and moved the google-news entry before google in the $social_icons array so it takes precedence during the regex loop.

I've also squashed the commits and cleaned up the commit message.

[laurelfulford]

Sorry, I didn't explain this change very well, @faisalahammad!

If there are cases where the fallback link icon is used for Google News (as mentioned in the issue description), then that URL and google.com could be mapped directly to the google icon, similar to how it's done for the apple icon:

		'google' => array(
			'google.com',
			'news.google.com',
		),

However, I couldn't recreate this exact issue myself -- when I added a news.google.com URL to the social links menu, the G icon was already being used on trunk.

It should just be falling back to the Google icon because it's a subdomain of google.com, but let me know if you have steps to recreate the link icon being used! If not, I don't think we need to make any changes to the code since we're using the same SVG.

Just let me know if that doesn't make sense! 🙂

[faisalahammad]

Hi @laurelfulford, thanks for the detailed feedback! 🙏

I've updated the approach based on your notes:

1. Removed the standalone google-news map entry (which was dead code without a corresponding SVG)
2. Added an explicit google map entry with both google.com and news.google.com, so the mapping is intentional rather than relying on the TLD fallback

This is the minimal fix you suggested in your second comment. Ready for another look whenever you have time!