VFS: share the canonical rootfs overlay helper#923
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
Move the recursive /etc merge landed with #907 out of the browser app and into the shared host VFS layer. Preserve caller-owned entries and source metadata, and keep missing canonical state, short reads, and capacity failures visible during image assembly.
This was referenced Jul 13, 2026
Member
Author
|
Closing this focused follow-up because its shared canonical rootfs overlay helper and strict preservation/error tests are now carried by #934 at exact green head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What remains
#907 already landed the recursive canonical
/etcmerge and the Chromium regression that proves browser test boots receive the OpenSSL files fromrootfs.vfs.This follow-up extracts the useful remainder from closed #909:
/etc, short reads, and target-capacity failures stay visible;ENOENT, short reads, andENOSPC;The Node host still mounts its canonical rootfs directly. The browser test runner and Git test call the shared helper while building their small kernel-owned images.
Deliberately left out
I did not replay #907's OpenSSL/rootfs runtime fix, add a second overlay path, change kernel-worker behavior, or touch rootfs/package inputs. The browser app now delegates to the helper while keeping the behavior #907 landed.
ABI and packages
There is no ABI change. Package metadata, package revisions, binary indexes, VFS source inputs, and published artifact bytes are unchanged.
Validation
Run through
scripts/dev-shell.sh:cd host && npm run typecheckcd host && npx vitest run test/vfs/rootfs-overlay.test.ts— 5 passedcd host && npx vitest run— 166 files passed; 1,360 tests passed; 2 expected failures; 42 skippedbash scripts/ci-check-browser-assets.sh— 92 imports resolvedcd apps/browser-demos && KANDELO_PLAYWRIGHT_PORT=5493 npx playwright test test/openssl-rootfs.spec.ts --project=chromium— 1 passedcd apps/browser-demos && KANDELO_PLAYWRIGHT_PORT=5495 npx playwright test --grep-invert "@slow" --project=chromium— 51 passed; 4 skippedbash scripts/check-abi-version.shgit diff --checkI did not run a separate interactive
./run.sh browsersession, Firefox/WebKit, libc/POSIX/Sortix suites, or performance benchmarks. This change does not alter guest syscall semantics, and it makes no performance claim.Follow-up to #909.