Browser tests: route guest HTTP through the configured CORS proxy.#880
Browser tests: route guest HTTP through the configured CORS proxy.#880brandonpayton wants to merge 1 commit into
Conversation
|
CI triage: the failed staging run did not reach this PR's test suites. This is independent of the CORS-proxy code path, but it remains a required CI gate. The PR's focused evidence is still the local host tests/typecheck/ABI check plus the exact Wget Chromium HTTPS/refusal run described above. The staging gate should be rerun after the binary baseline is repaired or the ABI-18 package rebuild becomes the selected baseline. |
35f040e to
13c66dc
Compare
|
ABI 18 history-only rebase update:
The rebase was conflict-free and changed no behavior or release-ledger data. The old ABI 16 composite-ledger failure belongs only to the superseded head. New staging run 29179249989 and browser smoke run 29179250021 are now evaluating the exact ABI 18 head. No local runtime suite is claimed for this history-only operation. |
|
Before reconstructing this PR directly on current |
Configure the browser test runner with its same-origin Vite proxy and keep a Chromium Wget regression for pages without a service-worker controller. Assert that BrowserKernel forwards the existing option and document the browser transport boundary.
13c66dc to
79dd37d
Compare
|
Closing this focused source PR because #934 now carries the unique browser test-runner wiring, proxy assertion, integration coverage, and non-duplicated documentation at exact green head |
What #907 already landed
#907 put the production
BrowserKernelOptions.corsProxyUrlpath onmain: the option already crosses the main-thread/worker protocol and reachesTlsNetworkBackend. This PR does not merge the old runtime commit verbatim.What remains here
BrowserKernelforwards the option in its init messageThe Chromium test uses the normal guest socket and Wget path. The local upstream receives exactly
/probe, which keeps the regression deterministic and avoids an external network dependency.What was removed
The stale copies of the BrowserKernel option, worker protocol field, worker backend setup, and TLS backend option documentation were removed because #907 already landed that production behavior. There are no production host-runtime changes in this diff. Node is unchanged.
ABI and package artifacts
This does not change the kernel/process ABI, generated ABI evidence, Wasm exports, package metadata, package revisions, release archives, indexes, or VFS image contents. The test uses the existing resolver-managed Wget artifact. No artifact revision is needed.
Validation
Run through
scripts/dev-shell.sh:host/test/browser-kernel.test.ts: 13 passed./run.sh browser --host 127.0.0.1 --port 5498 --strictPort: Vite started; the Kandelo page and test-runner page loaded, and the proxy rejected a request without a target with HTTP 400Not run locally: Firefox, WebKit, slow browser tests, libc/POSIX/Sortix suites, ABI snapshot check, package rebuild/publish checks, or performance benchmarks. Those suites are outside this test-only browser diff, and this PR makes no performance claim.