Browser: stop clearImmediate from retaining stale handles#782
Closed
brandonpayton wants to merge 1 commit into
Closed
Conversation
brandonpayton
force-pushed
the
gascity/kd-cfo/kd-c5i.9-fix-browser-clearimmediate-cancellation-leak-from-wave40
branch
from
July 13, 2026 18:20
67aa067 to
3f133f9
Compare
This was referenced Jul 13, 2026
Member
Author
|
Closing this focused source PR because its unique stale |
brandonpayton
deleted the
gascity/kd-cfo/kd-c5i.9-fix-browser-clearimmediate-cancellation-leak-from-wave40
branch
July 14, 2026 02:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
#907 already landed the broad PHP/platform batch, including its browser scheduling, worker coordination, and Vitest fixes, on ABI 39. This rewrite starts from current
mainand keeps that scheduling behavior.The unique work here fixes the remaining browser
clearImmediateleak:setTimeouthandle cannot cancel an unrelated immediate;This extracts the useful part of #769 commit
43189956c73ee37cea6ce41d0447b775cbbf1eb8. It rebuilds the existing focused #782 instead of opening a duplicate PR.What I removed
I did not replay #769's mmap, SQLite, VFS, package, or other composite changes. I also replaced #782's old numeric-handle implementation and stale pre-#907 ancestry instead of rebasing them mechanically.
ABI and packages
This does not change the kernel ABI, syscall marshalling, worker protocol, or generated ABI files. ABI stays at 39, and the ABI snapshot check passes.
No package manifest, package revision, VFS image source, or published package artifact changes. The browser images built for local validation were generated artifacts and are not part of this PR.
Validation
Run through
scripts/dev-shell.shon3f133f92bd971cc83fecefcd64709ed7b9f13ade:build.sh: passed;./run.sh browserpreparation and launch: passed;git diff --check: passed.Not run: Firefox, WebKit, slow browser tests, libc, POSIX, or Sortix suites. This change does not touch libc, syscalls, VFS semantics, or process state. GitHub CI is the remaining validation.
No performance claim is made, and performance was not measured.