Build: raise the build_wpcom timeout for trunk builds - #51059
Open
retrofox wants to merge 1 commit into
Open
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Raise
timeout-minuteson thebuild_wpcomjob in.github/workflows/build.ymlfrom 25 to 40, and refresh the stale comment next to it. Same change and same reason as #51029, which coveredbuild_allbut deliberately left the split jobs alone for lack of evidence. The evidence arrived a few hours after it merged.Every trunk push builds the whole monorepo split into
build_wpcomandbuild_nonwpcom(see the comment in thepreparejob). Since #50509 landed, the wpcom half takes more than 25 minutes, so the job is cancelled at its cap on every trunk push: run 30993937046 died at 25m21s, and the follow-up run for the next trunk commit did the same. While that holds,Push wpcom plugins to mirror reposandPush to mirror reposnever run and every mirror repo stays frozen at the last pre-#50509 state, which blocks the wpcomsh rolling releases and everything else that deploys from the mirrors.build_nonwpcomfinished in 14m53s on the same run, so its 25-minute value keeps a healthy margin and stays as is.The mirror pipeline self-heals once this merges: trunk builds cover the full tree, so the first green run pushes all mirrors up to date.
Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Nothing to test on a site. Confirm the diff touches only the
build_wpcomtimeout in.github/workflows/build.yml. The value proves itself on the first trunk push after merge:Build wpcom projectsshould complete in roughly 26 to 30 minutes and the two mirror-push jobs should run.