Skip to content

Stats: cast post IDs to integers when building the post views query - #51049

Merged
kangzj merged 1 commit into
trunkfrom
fix/stats-post-id-integer-casting
Aug 5, 2026
Merged

Stats: cast post IDs to integers when building the post views query#51049
kangzj merged 1 commit into
trunkfrom
fix/stats-post-id-integer-casting

Conversation

@kangzj

@kangzj kangzj commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Proposed changes

  • Cast post IDs to integers with absint() before they are used in the post views query — in both the jetpack-stats query builder and the jetpack-stats-admin quick-edit handler.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Run jp test php packages/stats and jp test php packages/stats-admin — all tests pass.

On Simple sites the post-views path built its SQL IN (...) list from the
caller-supplied post IDs after passing them through esc_sql(), which does
not constrain a value to an integer. Cast each post ID with absint() at
both the query-building sink (jetpack-stats) and the quick-edit AJAX
source (jetpack-stats-admin) so only integers are used.
@kangzj kangzj added the [Status] Needs Review This PR is ready for review. label Aug 5, 2026
@kangzj kangzj self-assigned this Aug 5, 2026
@kangzj kangzj added the [Status] Needs Review This PR is ready for review. label Aug 5, 2026
@kangzj
kangzj requested a review from dognose24 August 5, 2026 01:55
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/stats-post-id-integer-casting branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/stats-post-id-integer-casting
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/stats-post-id-integer-casting

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@kangzj
kangzj merged commit cc7aee8 into trunk Aug 5, 2026
88 checks passed
@kangzj
kangzj deleted the fix/stats-post-id-integer-casting branch August 5, 2026 02:27
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants