Random Redirect: test existing function compatibility - #51041
Random Redirect: test existing function compatibility#51041chrisbliss18 wants to merge 3 commits into
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Code Coverage SummaryCoverage changed in 1 file.
|
haqadn
left a comment
There was a problem hiding this comment.
Looks good and tests well. Great job on the additional coverage.
The merge-base changed after approval.
0447bae to
09ac1a8
Compare
09ac1a8 to
2b9666c
Compare
Proposed changes
jetpack_matt_random_redirect()before Jetpack loads its module.This PR is stacked on #51037 so its test suite remains green. It can be retargeted to
trunkafter that PR merges.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
Start and install the Jetpack Docker environment if needed:
Run the Random Redirect tests:
Confirm all 12 tests pass, including
test_loads_with_existing_random_redirect_function.Red/green behavior was also verified directly with the standalone fixture:
5d8235ab7c), the fixture exits with status 255 and the originalCannot redeclare jetpack_matt_random_redirect()fatal.OK, and the complete Random Redirect test class passes: 12 tests and 13 assertions.